From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C91501A33B47; Thu, 5 Mar 2026 12:57:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C91501A33B47 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1772704627; bh=FjC/5ODhKkOQE1+OnfwNLiYt+PQTgkA02Xqh++gKBRw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=zAnv9b1jiS5Dq9VjIMc89ePZHCG4sWhXVwDlx3Wz9zQVarfBs8uifLC415zbKFQzk qS4xssdOMv/PTk9r4ADKWtGjCX0Pb6h4E5kf+VjxeyOcoqR1ARGpae56YsxuD3/clQ 0KJr/KlVot2iHuzsTcWiZCz0EG3hSKZCM6xTJqto= Received: from send219.i.mail.ru (send219.i.mail.ru [95.163.59.58]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F23F21A33B46 for ; Thu, 5 Mar 2026 12:57:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F23F21A33B46 Received: by exim-smtp-558f87dcd7-8hpd7 with esmtpa (envelope-from ) id 1vy5S4-000000006bT-2YQN; Thu, 05 Mar 2026 12:57:05 +0300 Date: Thu, 5 Mar 2026 12:57:54 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <20260302081443.1058-1-skaplun@tarantool.org> <07642828-4ad9-4532-a195-b24afa22963f@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07642828-4ad9-4532-a195-b24afa22963f@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9406AA218EDC7AA27B42CEFEB667FFC919782AE9FC69328E1182A05F538085040C8A4FCBB3E3360D33DE06ABAFEAF67056461B183B04F4BBED1623C919B7DA8E909C93364CE201E3D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F65C230EDDCD559EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375666F44369204E714C7601C21FBCA778C707CA0E87B4B715B358DA8EAC12633A256389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249E6B67F0F38050C1976E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B78BD03DC0BC2E2FB3AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7350555CCFDA08FA3FAC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A51387758ADADD4D765002B1117B3ED696BBF236E8D014507569995D676B7B4CBE823CB91A9FED034534781492E4B8EEAD4ECBDE8281F904F9BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659D98EBB8D967666BC1AF45614860B319B63CF3CCA2DC62B065D708CA95C06B641B9732CD5B08428CEB8341EE9D5BE9A0A47F5B49E5F419983DB62EFCAF3B72F20E5CD4FB1A065D30D8CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVbwN8XFWZxQUMmcblBrfsoY= X-Mailru-Sender: 583F1D7ACE8F49BDD951BA70C165859EBCFD918B7B463EF11356DD24693B53BC0D404A5B6FEC67BEBF9478A0D2748FCDF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] DUALNUM: Add missing type conversion for FORI slots. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review. See my answer below. On 04.03.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! > > The bug cannot be reproduced with reverted fix. > > CMake: cmake -S . -B build -DCMAKE_BUILD_TYPE=Debug -DLUAJIT_NUMMODE=2 You need to enable assertions as well. > Sergey > > On 3/2/26 11:14, Sergey Kaplun wrote: > > From: Mike Pall > > > > Reported by Sergey Kaplun. > > > > (cherry picked from commit 406cf69b3ae0a3ecd5ede2bb97b937b7a5d92074) > > > > `rec_for_loop()` narrows the FORL index values by getting them from the > > runtime. In case when the `start`, `stop`, `step` control variables are > > already loaded to the slots, their TRef isn't converted to the > > corresponding type. This leads to the following inconsistent IR dump and > > to the assertion failure later: > > | 0002 > int SLOAD 10 TCI > > | 0003 int ADD 0002 +1. > > | 0004 > int LE 0003 +1. > > | 0005 int ADD 0003 +1. > > | 0006 > int GT 0005 +1. > > > > This patch adds the missing type conversion. > > > > Sergey Kaplun: > > * added the description and the test for the problem > > > > Part of tarantool/tarantool#12134 > > --- > > > > Branch:https://github.com/tarantool/luajit/tree/skaplun/lj-1413-missing-conv-fori > > Related issues: > > *https://github.com/LuaJIT/LuaJIT/issues/1413 > > *https://github.com/tarantool/tarantool/issues/12134 > > -- Best regards, Sergey Kaplun