From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2B7581B5F2BE; Wed, 4 Mar 2026 17:31:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2B7581B5F2BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1772634664; bh=55X/xDFF1bHOGsZCJKmy1z6ufASvhqpBT8bKZI0kgOA=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=fuVbPMmkiMHwNmhyHziBfncMx+/uVL8x00sH5J5OzYdhIk9/Owx/99hXJiyd4wgZw fEqH+faN9LTGhpL8BktvK9QQqIYVCWGhvw6tVmkrYAonbJ/ipx1qw2j6uroZps7yj7 aFaOteAZOgbb0NDcteWoe3ONm7Znlo/3d5esJQF8= Received: from send152.i.mail.ru (send152.i.mail.ru [89.221.237.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4E8901B5F2BA for ; Wed, 4 Mar 2026 17:31:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4E8901B5F2BA Received: by exim-smtp-558f87dcd7-lwq8m with esmtpa (envelope-from ) id 1vxnFb-000000004mu-2Tsv; Wed, 04 Mar 2026 17:31:01 +0300 Date: Wed, 4 Mar 2026 17:31:48 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <20260302082317.4082-1-skaplun@tarantool.org> <26109d50-0770-4007-ba9e-1b2f747c8a3d@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26109d50-0770-4007-ba9e-1b2f747c8a3d@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9FE49BA1A5307ACBF0F5BBED206C6FCDF347C87ECC44DA82D00894C459B0CD1B961B93754CD6A3946D4FF92D56319F1976766B9CAA9F9EDD25DB31880C68A19F1E5719F5EA8C3A75A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566CF7C7957E4725328406CB2F47BF8368D876912E9D8BBD0B2ACDC8D764E229FEF389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B65FF0BFC5AEE34BE6CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22493271950E746CB25C76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8BEE6865575290A7923AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735B58781B77DE60D36C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A55EA1CE783C7EBD505002B1117B3ED696C636E5369006B4DECA7E60A991436CA2823CB91A9FED034534781492E4B8EEAD220496FFA5CD4785BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65930AF4425580E81ABC5DBD832CBF60B787F78CBA797B2D69ED88243CC36A634AC11D2FBFCB7797FA7B8341EE9D5BE9A0AD1557DBC268A25010D3591796D348C511CBCC649E5680C328CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVbwN8XFWZxQUL4kpqpivRcg= X-Mailru-Sender: 520A125C2F17F0B17094CDC02B85F11BC6BC5C57F762B6D43DE06ABAFEAF67055C6C2C2B102A6FFEB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix reporting of an error during error handling. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! See my answer below. On 04.03.26, Sergey Bronnikov wrote: > Hi, Sergey! > > thanks for the patch! LGTM with minor comments below. > > Sergey > > On 3/2/26 11:23, Sergey Kaplun wrote: > > From: Mike Pall > > > > Reported by Sergey Kaplun. > > > > (cherry picked from commit 54a162688ed25902122077149df9b456bc5a763e) > > > > +-- OOM on the creation of ERRERR message. > > +coroutine.wrap(function() > > + allocinject.enable_null_alloc() > > + local st, msg = xpcall(error, error) > > + allocinject.disable() > > +test:ok(not st, 'OOM ERRERR incorrect status') > > + -- Prevent preallocated error message. > > +test:ok(msg:match('error in ' .. 'error handling'), > > + 'OOM ERRERR incorrect errmsg: ' .. msg) > > +end)() > > + > > +-- OOM in the error handler. > > +coroutine.wrap(function() > > + local function errmem() local _ = {} end > > + allocinject.enable_null_alloc() > > + local st, msg = xpcall(error, errmem) > > + allocinject.disable() > > +test:ok(not st, 'OOM incorrect status') > > + -- Prevent preallocated error message. > > +test:ok(msg:match('error in ' .. 'error handling'), > > + 'OOM incorrect errmsg: ' .. msg) > > +end)() > > + > > +-- STKOV in the error handler. > Why abbreviation is used? May be "stack overflow"? Feel free to ignore. This is done to be consistent witht the OOM abbreviation above. If you don't insist, I would leave them as is. > > +coroutine.wrap(function() > > + local function stkov() stkov() end > > + local st, msg = xpcall(error, stkov) > > +test:ok(not st, 'STKOV incorrect status') > > + -- Prevent preallocated error message. > > +test:ok(msg:match('error in ' .. 'error handling'), > > + 'STKOV incorrect errmsg: ' .. msg) > > +end)() > > + > > +test:done(true) -- Best regards, Sergey Kaplun