Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Fix reporting of an error during error handling.
Date: Tue, 10 Mar 2026 17:21:33 +0300	[thread overview]
Message-ID: <aac84fb0-186f-4a32-89cc-62148137509b@tarantool.org> (raw)
In-Reply-To: <aahCVKO24cEi2192@root>

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

Hi, Sergey!

On 3/4/26 17:31, Sergey Kaplun wrote:


<snipped>

>>> +-- OOM in the error handler.
>>> +coroutine.wrap(function()
>>> +  local function errmem() local _ = {} end
>>> +  allocinject.enable_null_alloc()
>>> +  local st, msg = xpcall(error, errmem)
>>> +  allocinject.disable()
>>> +test:ok(not st, 'OOM incorrect status')
>>> +  -- Prevent preallocated error message.
>>> +test:ok(msg:match('error in ' .. 'error handling'),
>>> +          'OOM incorrect errmsg: ' .. msg)
>>> +end)()
>>> +
>>> +-- STKOV in the error handler.
>> Why abbreviation is used? May be "stack overflow"? Feel free to ignore.
> This is done to be consistent witht the OOM abbreviation above.
> If you don't insist, I would leave them as is.
Ok, let's leave as is. LGTM
>
>>> +coroutine.wrap(function()
>>> +  local function stkov() stkov() end
>>> +  local st, msg = xpcall(error, stkov)
>>> +test:ok(not st, 'STKOV incorrect status')
>>> +  -- Prevent preallocated error message.
>>> +test:ok(msg:match('error in ' .. 'error handling'),
>>> +          'STKOV incorrect errmsg: ' .. msg)
>>> +end)()
>>> +
>>> +test:done(true)
> <snipped>
>

[-- Attachment #2: Type: text/html, Size: 2152 bytes --]

      reply	other threads:[~2026-03-10 14:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02  8:23 Sergey Kaplun via Tarantool-patches
2026-03-04 13:44 ` Sergey Bronnikov via Tarantool-patches
2026-03-04 14:31   ` Sergey Kaplun via Tarantool-patches
2026-03-10 14:21     ` Sergey Bronnikov via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aac84fb0-186f-4a32-89cc-62148137509b@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] Fix reporting of an error during error handling.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox