From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 82E3F1728527; Tue, 3 Mar 2026 15:00:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 82E3F1728527 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1772539235; bh=0AHEgk++MZF2TtD+5aVmSBbpb95FCRZW4L2wy8/voFQ=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=i5poxRR8zhDAJUYV22spxCRoe5ndpDPJHHhb/pk79EEfI6qpscfK+6qtigEvEM1xo sFBMRdZ7kmdL+lZeDz2hjrROIVralC1OGG5KTRKdaYJ9ho+6Q22BWkBFvP5JKlIq90 ZPgd3185Ww6Zis7mP2hryNtazQPWdrI8ReWAf5Nw= Received: from send219.i.mail.ru (send219.i.mail.ru [95.163.59.58]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2962F1728520 for ; Tue, 3 Mar 2026 15:00:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2962F1728520 Received: by exim-smtp-558f87dcd7-khp4f with esmtpa (envelope-from ) id 1vxOQT-00000000eFC-079V; Tue, 03 Mar 2026 15:00:33 +0300 Date: Tue, 3 Mar 2026 15:01:22 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <20260225121140.18847-1-skaplun@tarantool.org> <0aee43fd-f0a6-410b-b67b-10461724a66f@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0aee43fd-f0a6-410b-b67b-10461724a66f@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9B83249A38DAD341BB117451084EABF5E434F3916F9322781182A05F5380850404C228DA9ACA6FE2789098AA571663FCD3DE06ABAFEAF6705DCFB7422CD44373415FC45B56F842B42EA49DAD9745199E0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7081BBE264C6D7F42EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566CF7C7957E4725328D5EA52226BF8785781178B62E91CE8B8901C64F6426D350B389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249964B8366DC5BCEDF76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8BA6604729F42D483A3AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7352629B07FD02F83A6C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A512C3680FB92BE9FC5002B1117B3ED69634C6BEC57EC4FFA95B6221DB6D7A72AD823CB91A9FED034534781492E4B8EEADC24E78AA85F86F6CBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659D0CB733EABA473319A22CE4EF788C186CDAAF9C6DD7AC28C462B199496DB40BECDC58C898A77E3B9B8341EE9D5BE9A0AC77EB48DDBA84AF87B7930F9456967BA59DCDE0D62155FCB8CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVbwN8XFWZxQUTBw4ams48xw= X-Mailru-Sender: 583F1D7ACE8F49BDD951BA70C165859E0BA675C6567C08644756507F36A35F4B3470CF8D34F160C11AAD2DD0D6518CF2F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Prevent snapshot purge while recording a function header. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! See my answer below. On 03.03.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with a minor comment. > > Sergey > > On 2/25/26 15:11, Sergey Kaplun wrote: > > + > > +local checkers = {} > > + > > +-- Called twice for the pseudo-type that aliases base Lua type via > > +-- checkers map. > > +local function checks(expected_type) > > + -- Value expected to be `checks_tab()` or `checks_obj()` > > + -- argument. It is always a table. > > + local _, value = debug_getlocal(2, 1) > > + -- Simple stitching function. Additional arguments are needed to > > + -- occupy the corresponding slot. > > It is not clear for me why this corresponding slot is needed. > > The bug can be reproduced without double nil's passed to math_modf(). Not for all builds (i.e. GC64 and non-GC64). > > > + math_modf(0, nil, nil) > > + -- Start trace now, one iteration only. > > + -- luacheck: ignore 512 > > + while true do > > + -- Base type? > > + if type(value) == expected_type then > > + return true > > + end > > + -- Pseudo types fallbacks to the map. > > + local checker = checkers[expected_type] > > + -- For the xpcall. > > + if checker(value) == true then > > + return true > > + end > > + break > > + end > > + error('Unreachable path taken') > > +end -- Best regards, Sergey Kaplun