From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A0EE119EEE9C; Tue, 10 Mar 2026 14:06:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A0EE119EEE9C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1773140792; bh=vtdKNw/GaTa2ZEFuvRnGx900t/eaJQj343zy8wuaYe8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=tuyh/G/xoN0ADe80Eb9FfwkGWFwd50Y3ZyJCEUUakCu+XDHSQsNm8NFoMf0rXIVKY ah1UxhAOe/QbpzS03uJ8QcCmhssh4zJTjeVb/bH719wnksvAnKNVaNe6WGsds08sz3 xhWfJwfHezWsPhaiJtJ2A3U7ZWh2qEQhU7jzAxtE= Received: from send57.i.mail.ru (send57.i.mail.ru [89.221.237.152]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1139416D614B for ; Tue, 10 Mar 2026 14:06:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1139416D614B Received: by exim-smtp-695fc89d9f-2s7vc with esmtpa (envelope-from ) id 1vzuuz-00000000HLe-3Xjn; Tue, 10 Mar 2026 14:06:30 +0300 Date: Tue, 10 Mar 2026 14:07:22 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <208fb058-9dbb-469c-b5e1-6ff3a532e971@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <208fb058-9dbb-469c-b5e1-6ff3a532e971@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91ABAE9865AC7DC88B865A22E496AAB539DFA8EEAAC77DF87182A05F538085040C839E8B8B6DACF9D3DE06ABAFEAF6705BF140B3E18139C2D6BBFF9B092BF2BA66B7995677FB1BAB6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375665A08EF23E7B416ABED3633A47F20817C6699B08E1A56687EA3A9BF99E8A5E4EE389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C078FCF50C7EAF9C588941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6AEEA5BB16A939343CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249389ED70FDB73D44F3AA81AA40904B5D9CF19DD082D7633A0C84D3B47A649675F3AA81AA40904B5D98AA50765F790063750C2B358740BB6D8EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3335407143AA9223635872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5583A970D6CC57A635002B1117B3ED69667B21F5A66E3D12654BB1175C6E7DD94823CB91A9FED034534781492E4B8EEAD37F46C620FF2CAEEBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659152A6D6C21B0D598E93AE125E32DA5215284DA1B0A456CBC10E5C65CE13D79AEB9DC24AB902BD764B8341EE9D5BE9A0A239ADBDC5AC9E5F76A6BECC88F3A16B13D4A066F2041BA698CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdbVVJCphTR/Ui0CBCoZLwU= X-Mailru-Sender: 583F1D7ACE8F49BDD951BA70C165859E4A01074E9F362DB604DE63E6493D4605FD6144AB66FB3B6CFD4CDEAAF4387D75F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A84198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Fix edge cases when generating IR for string.byte/sub/find. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment and rebased the branch to the current tarantool/master. On 10.03.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with a minor comment below. > > Sergey > > On 3/6/26 16:42, Sergey Kaplun wrote: > > From: Mike Pall > > > > Contributed by XmiliaH. > > > > (cherry picked from commit af9763a50da87ff8ba16e828cbd5664135e05a88) > > > > The generated ADD/SUB IRs for the calculation of indexes in the string > > for the aforementioned build-ins don't check the overflow. This may lead > s/build-ins/built-ins/ Fixed, thanks! > > to the incorrect results, incorrect trace semantics, or invalid memory > > access. Also, the negative values may pass the UGT guard check emitted > > for the positive `end` position and lead to the incorrect results on the > > trace. > > > > This patch fixes this by using guarded ADDOV/SUBOV instead. The UGT IR > > is replaced with GT. > > > > Sergey Kaplun: > > * added the description and the test for the problem > > > > Part of tarantool/tarantool#12134 > > --- > > -- Best regards, Sergey Kaplun