From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 76797469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 13:19:58 +0300 (MSK)
References: <20201112195121.191366-1-gorcunov@gmail.com>
 <20201112195121.191366-10-gorcunov@gmail.com>
 <11e6dccd-feba-e55c-4f0b-0d73e50d8b6d@tarantool.org>
 <20201113101337.GD2021@grain>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <aa67e709-9044-3b34-45a1-aa2ed8f415e3@tarantool.org>
Date: Fri, 13 Nov 2020 13:19:57 +0300
MIME-Version: 1.0
In-Reply-To: <20201113101337.GD2021@grain>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH 09/11] qsync: drop redundant type
	convention
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>


13.11.2020 13:13, Cyrill Gorcunov пишет:
> On Fri, Nov 13, 2020 at 01:11:05PM +0300, Serge Petrenko wrote:
>> 12.11.2020 22:51, Cyrill Gorcunov пишет:
>>> Void pointer can be cast implicitly.
>> We usually use explicit casts. Check `applier.cc`, `alter.cc` and some other
>> places.
>> This isn't in our style guide though, so I'm fine with the change.
>>
>> Let's see what Vlad has to say.
> The casts are required for C++ but for plain C void pointer can be
> casted to anything, as it is guaranteed by language standart. So
> such casting is simply not needed.
I see, thanks!
LGTM then.

-- 
Serge Petrenko