From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 09FA31944AD2; Tue, 13 Jan 2026 18:46:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 09FA31944AD2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1768319211; bh=3mQbaRSbBYBlPA2nyqxGw94ulv+/O7MrzqiTHqcYIqM=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=zXgwWCeWmOkzAZyfXN4ZwPs5DTaGXSPS2DmgTWgviKNyX5yRc6hpxFpJHVKNdyq8z ygOEO/RXf3HVCInhhPN6gm4slz2lZV1lRCIrxfLQjVjpZAI7g/0NUEG0T1jh9xdxgm oOFchzszgl7VXFZj59oZdglZNCbu8wlVRd+SBkH4= Received: from send265.i.mail.ru (send265.i.mail.ru [95.163.59.104]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5F2971944AD2 for ; Tue, 13 Jan 2026 18:46:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5F2971944AD2 Received: by exim-smtp-7b4fb89df9-lsqrg with esmtpa (envelope-from ) id 1vfgbY-00000000MQQ-21BN; Tue, 13 Jan 2026 18:46:48 +0300 Date: Tue, 13 Jan 2026 18:46:59 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <17eca2e353ca35724c022af610f1295328838561.1766738771.git.skaplun@tarantool.org> <86be55de-2fc3-4847-9d32-60682c9f6db2@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86be55de-2fc3-4847-9d32-60682c9f6db2@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD705C26DA7DFA1BE5C83EDDE7B55BBC1E182A05F538085040F9BC2C69112F79CB3DE06ABAFEAF670584CBDF7B4EC27E3A916540A36209A0AB8ACF784BD97B3DAF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D9C4478D0B876341EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FE9EFE935CD7C6AE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2A9BF505FD786F9E02E070BE324C7D3C472AD54E9EE18A279F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249957A4DEDD2346B42CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0A3E989B1926288338941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3FB9365559B687AC835872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A517DEB08EE1A7443B5002B1117B3ED6962CC8C1B919A0F6B269995D676B7B4CBE823CB91A9FED034534781492E4B8EEADEEA082C9A12FE455BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659E0417CEC30ED130D8C7B1BFE504E564A1C932A1FC68313C1626EAA2A41EDAF86701185608FE464F9B8341EE9D5BE9A0A826432E905281431DC8C75BC68ED23EBE81B27BEB10AB5F78CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVVt0N+pdRHOZpSlx9TOvRdY= X-DA7885C5: 239AE9FBABCEB1FAF255D290C0D534F9CA5AE1B8BD60880FEC2FEF2E476F370374BD13159239B0365B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD259B750DC4944043D3AF871D2D088E11601751767754394FCE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 39/41] perf: add a script for the environment setup X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey, Thanks for the comment. See my thoughts below. On 13.01.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with minor comment below. > > Sergey > > On 12/26/25 12:18, Sergey Kaplun wrote: > > The patch adds a script for setting the environment before running > > performance tests. The script originated from the Tarantool's repository > > [2]. Most of the settings are taken from the Tarantool's wiki page > > dedicated to the benchmarking [1]. > > > > [1]:https://github.com/tarantool/tarantool/blob/dcdb3ee83b3d6324011e704b5a3f4ee3e19bbf47/perf/tools/setup_env.sh > > [2]:https://github.com/tarantool/tarantool/wiki/Benchmarking > > --- > > perf/helpers/setup_env.sh | 135 ++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 135 insertions(+) > > create mode 100755 perf/helpers/setup_env.sh > > > > diff --git a/perf/helpers/setup_env.sh b/perf/helpers/setup_env.sh > > new file mode 100755 > > index 00000000..043d3c88 > > --- /dev/null > > +++ b/perf/helpers/setup_env.sh > > @@ -0,0 +1,135 @@ > > +#!/bin/sh > I propose to add a note to the comments that the original version of > script is in the tarantool repository. Is it necessary? I'm not sure that we keep them intact since LuaJIT and Tarantool may require different setups. Also, the origin of the file is mentioned in the commit message. > > + > > +# The script sets up a Linux operating system before running > > +# LuaJIT benchmarks. See more details in [1]. > > +# > > +# [1]:https://github.com/tarantool/tarantool/wiki/Benchmarking > > + -- Best regards, Sergey Kaplun