From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2FF3E16F2A53; Sat, 3 Jan 2026 09:07:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2FF3E16F2A53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1767420474; bh=1Ip+snGNkht5gC7e78wPvKBTVd4ho0uVusDe6thoLxQ=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=sPqdmUg6HWQz8n2Vy93V726i0ihpphqdoZJx/lWDdhQb1CLI/mVU2320TZWBJlgSs DsMuUPxLnTMSoz4GD18ok2bTc8qrt31dmyDXvz72fQnuVmx8T5UKOtY/p9Ktw8fJBp z55U8+An8wvkkfsYTRUGSEMa92BE6PrfkIZywQEs= Received: from send194.i.mail.ru (send194.i.mail.ru [95.163.59.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 19A1516F2A45 for ; Sat, 3 Jan 2026 09:07:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 19A1516F2A45 Received: by exim-smtp-7b4fb89df9-8h54m with esmtpa (envelope-from ) id 1vbuno-00000000MLf-0zg7; Sat, 03 Jan 2026 09:07:52 +0300 Date: Sat, 3 Jan 2026 09:07:55 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBDA796860CCD9352B78452F76EDBE9CB18182A05F538085040CC803133AA9715123DE06ABAFEAF6705F41BB8E246DDBC59154A738D58A9DE3387940C845C9D7C7C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74B7EDB5828CF9C27EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637ECAF4C2CEE0D0B2F8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B27EEF88C87C66EE892E070BE324C7D3C418766B94411FC6A2F6B57BC7E64490618DEB871D839B73339E8FC8737B5C22498424CA1AAF98A6958941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE75A9E79F66F1C28F3731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A58D213000BE5BEA155002B1117B3ED696E1F2D4A6C3D4BCD5C66B2B37046EC955823CB91A9FED034534781492E4B8EEAD5E90D3DD2A5B7EAFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6593557632485A8F76C0D2D638055264B1326B25D99A65DB013FB172ED4CBE29C1F4B02739EC80C758CB8341EE9D5BE9A0A88A4D2B47EA7577CE4DF707A4EF339FA891B1126448D12378CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVTZJppT4ZVHRy3wYD93P7ds= X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD2A6384519A717A851C8AECFEC15F91B6D12F3B65759E44F40E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 29/41] perf: adjust scimark-fft in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answer below. On 02.01.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with a minor comment. > > Sergey > > On 12/26/25 12:18, Sergey Kaplun wrote: > > This patch adjusts the aforementioned test to use the benchmark > > framework introduced before. The default arguments are adjusted > > according to the file. The arguments to the script still > > can be provided in the command line run. > > > > Checks are omitted since they were not present in the original suite, > > plus the precise result value depends on the input parameter. > > --- > > perf/LuaJIT-benches/scimark-fft.lua | 19 ++++++++++++++++++- > > 1 file changed, 18 insertions(+), 1 deletion(-) > > > > diff --git a/perf/LuaJIT-benches/scimark-fft.lua b/perf/LuaJIT-benches/scimark-fft.lua > > index c05bb69a..96535774 100644 > > --- a/perf/LuaJIT-benches/scimark-fft.lua > > +++ b/perf/LuaJIT-benches/scimark-fft.lua > > @@ -1 +1,18 @@ > The small test description was not added. Is it intentional? Yes, see my answer in the previous series. The description and main payload are in the file. I see no reason for duplication. > > -require("scimark_lib").FFT(1024)(tonumber(arg and arg[1]) or 50000) > > +local bench = require("bench").new(arg) > > + > > +local cycles = tonumber(arg and arg[1]) or 50000 > > +local benchmark > > +benchmark = { > > + name = "scimark_fft", > > + -- XXX: The description of tests for the function is too > > + -- inconvenient. > > + skip_check = true, > > + payload = function() > > + local flops = require("scimark_lib").FFT(1024)(cycles) > > + benchmark.items = flops > > + end, > > +} > > + > > +bench:add(benchmark) > > + > > +bench:run_and_report() -- Best regards, Sergey Kaplun