From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C234616F2A54; Sat, 3 Jan 2026 09:10:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C234616F2A54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1767420649; bh=di8uJRWyBF9uYMSwb943/tZfxaMDGLQTjINXpncFszY=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=h27xw9dNgzQBrsIIYmCooZ5nVt+cbSXzkPca3bSKtlBOfodr1BI48nQS7uNYcUedT hGls4L5GAP4lftfylANTvhpmrUi6304bpvA+mhdjqOgj15IJZLNgs8FyEO8/pNK1PH RLyXX+BNNFnxCcAObfhDs5PsVPTZznun4aRyIFGI= Received: from send195.i.mail.ru (send195.i.mail.ru [95.163.59.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 12EEE16F2A54 for ; Sat, 3 Jan 2026 09:10:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 12EEE16F2A54 Received: by exim-smtp-7b4fb89df9-6bqm6 with esmtpa (envelope-from ) id 1vbuqe-00000000Y15-0KTQ; Sat, 03 Jan 2026 09:10:48 +0300 Date: Sat, 3 Jan 2026 09:10:51 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <53e4ef7ccd9ab4aa9877b53bd66a0cce6d146cb3.1766738771.git.skaplun@tarantool.org> <02454c83-21b1-4e0a-9a98-b5a9a060d398@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02454c83-21b1-4e0a-9a98-b5a9a060d398@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD390EF5E93CD1F77387498C0EC589AA68182A05F538085040C4286A72C27AA8863DE06ABAFEAF670583BF0516F0432CE8154A738D58A9DE335E6CE7239E2C5700 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F09446BC3D835A58EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F88016AB904663428638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B261582C93C599483E2E070BE324C7D3C4A1D11806BBDCF0F9F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249957A4DEDD2346B42CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C309A7649CC036878F35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5180E1BC11A4D066D5002B1117B3ED69683A6BB2C104FC918B74D9144D44E4FCF823CB91A9FED034534781492E4B8EEADB73CFAAED92B6E13BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6595879898F095AD75E2F249E32E9F05CA77A729ADAC15C25B4A3D072B0542CF3608E193F3605A227DDB8341EE9D5BE9A0A9628CDA0AD5118701D9795487932DDAB67190C6DF1C609A38CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVTZJppT4ZVHRCk7dJjpH9XQ= X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD22481EF539F107FD0E65CC24224AD9F1A58B93D38BC4147BAE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 27/41] perf: adjust scimark-2010-12-20 in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answer below. On 02.01.26, Sergey Bronnikov wrote: > Hi, Sergey! > > thanks for the patch! LGTM with a minor comment > > Sergey > > On 12/26/25 12:17, Sergey Kaplun wrote: > > This patch adjusts the aforementioned test to use the benchmark > > framework introduced before. The default arguments are adjusted > > according to the file. The arguments to the script still > > can be provided in the command line run. > > > > The time for each subsequent benchmark is increased up to 4 seconds, > > accoring the defaults in the "bench" framework. The main difference > > between this test and others that will be added in next commits is > > the usage of FFI arrays instead of plain Lua tables. > > --- > > perf/LuaJIT-benches/scimark-2010-12-20.lua | 92 ++++++++++++---------- > > 1 file changed, 52 insertions(+), 40 deletions(-) > > > > diff --git a/perf/LuaJIT-benches/scimark-2010-12-20.lua b/perf/LuaJIT-benches/scimark-2010-12-20.lua > > index 353acb7c..4b80ffe2 100644 > > --- a/perf/LuaJIT-benches/scimark-2010-12-20.lua > > +++ b/perf/LuaJIT-benches/scimark-2010-12-20.lua > > while arg and arg[1] do > > local a = table.remove(arg, 1) > > - if a == "-noffi" then > > + if a == "noffi" then > > package.preload.ffi = nil > > - elseif a == "-small" then > > + elseif a == "small" then > > SIZE_SELECT = "small" > > - elseif a == "-large" then > > + elseif a == "large" then > these options are absent in usage (--help), why? I suppose there is no need for it. This still may be done if you are exploring the benchmark behaviour. But you will read its sources in this case anyway. These options are retained for backward compatibility with the original version. > > SIZE_SELECT = "large" > > elseif benchmarks[a] then > > - local p = benchmarks[SIZE_SELECT][a] > > - measure(MIN_TIME, a, tonumber(arg[1]) or p[1], tonumber(arg[2]) or p[2]) > > + local cycles = benchmarks[SIZE_SELECT][a].cycles > > + local p = benchmarks[SIZE_SELECT][a].params > > + local b > > + b = { > > + name = a, > > + -- XXX: The description of tests for each function is too > > + -- inconvenient. > > + skip_check = true, > > + payload = function() > > + local flops = measure(a, cycles, tonumber(arg[1]) or p[1], > > + tonumber(arg[2]) or p[2]) > > + b.items = flops > > + end, > > + } > > +bench:add(b) > > +bench:run_and_report() > > return > > else > > - printf("Usage: scimark [-noffi] [-small|-large] [BENCH params...]\n\n") > > - printf("BENCH -small -large\n") > > + printf("Usage: scimark [noffi] [small|large] [BENCH params...]\n\n") > > + printf("BENCH small large\n") -- Best regards, Sergey Kaplun