From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 47CBB16F2A42; Sat, 3 Jan 2026 09:05:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 47CBB16F2A42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1767420316; bh=FtiMv8buxxtsOxvmxAJ7WlgtALiKtBoo81Eb+/Tc+6c=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=RuWW+9OK2BLewQZmzZyGKjIimYugkyAmk5yp+9GUaVy3e5mNlaBK21pgqbMeC0tHy UCm5QAd7BVwxbsjzTOohKrENIltm960Fyd33F1b9WgRiO/bb1tdd2iaWBL4CoDwCfh BGTkPxerTqL6MwTEameTwdN9BmplzU9d49mAgufg= Received: from send104.i.mail.ru (send104.i.mail.ru [89.221.237.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C479016F2A42 for ; Sat, 3 Jan 2026 09:05:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C479016F2A42 Received: by exim-smtp-7b4fb89df9-w58cc with esmtpa (envelope-from ) id 1vbulF-000000005bm-4BPW; Sat, 03 Jan 2026 09:05:14 +0300 Date: Sat, 3 Jan 2026 09:05:17 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <3a9ba410-3874-4609-8598-d69de057d0c1@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a9ba410-3874-4609-8598-d69de057d0c1@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD136B1DE29D0A14187F3E33C5CB109B4B182A05F538085040B5B1A7AED1F9445D3DE06ABAFEAF67057CFD7A599667A703154A738D58A9DE331E13962C942EC85E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AB524098FB2F2222EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376A27C8034CCD05E58638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2E0BEE7F3743BF1882E070BE324C7D3C44571C578DCED724FF6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249957A4DEDD2346B42CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0A29E2F051442AF778941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C309A7649CC036878F35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5F730100E94C0520F5002B1117B3ED696561F5A9F88D1D3521A1B8FE1FED62FE8823CB91A9FED034534781492E4B8EEAD887A4342A344B6EDBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659BC1302D47214C81505819677C12D8FFB530C864A82B2EE51FAE05DCC0974F64655F5D94D4F08AFEDB8341EE9D5BE9A0A3DFF08D92D7ACAF6255FD67721137758BFFAC9014DF65F558CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVTZJppT4ZVHRP7B0tp33Zr8= X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD284C52AC6F8CAB2E0DDE09131CCF8B8C1BE3E5B3BBDBC0A50E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 31/41] perf: add scimark-mc in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answer below. On 02.01.26, Sergey Bronnikov wrote: > Hi, Sergey! > > thanks for the patch! LGTM with a minor comment. > > Sergey > > On 12/26/25 12:18, Sergey Kaplun wrote: > > This patch adds the aforementioned test with the use of the benchmark > > framework introduced before. The default arguments are adjusted > > according to the amount of cycles in the file. > > The arguments to the script can be provided in the command line run. > > > > Checks are omitted since they were not present in the original suite, > > plus the precise result value depends on the input parameter. > > --- > > perf/LuaJIT-benches/scimark-mc.lua | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 perf/LuaJIT-benches/scimark-mc.lua > > > > diff --git a/perf/LuaJIT-benches/scimark-mc.lua b/perf/LuaJIT-benches/scimark-mc.lua > > new file mode 100644 > > index 00000000..d26b6e48 > > --- /dev/null > > +++ b/perf/LuaJIT-benches/scimark-mc.lua > > @@ -0,0 +1,19 @@ > > +local bench = require("bench").new(arg) > > + > > +local cycles = tonumber(arg and arg[1]) or 15e7 > Do we want to add this to the usage? I suppose there is no need for it. This still may be done if you are exploring the benchmark behaviour. But you will read its sources in this case anyway. > > + > > +local benchmark > > +benchmark = { > > + name = "scimark_mc", > > + -- XXX: The description of tests for the function is too > > + -- inconvenient. > > + skip_check = true, > > + payload = function() > > + local flops = require("scimark_lib").MC()(cycles) > > + benchmark.items = flops > > + end, > > +} > > + > > +bench:add(benchmark) > > + > > +bench:run_and_report() -- Best regards, Sergey Kaplun