From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CB1A316C8170; Sat, 3 Jan 2026 09:04:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CB1A316C8170 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1767420259; bh=0Brn8mMFyuBEhz4DY9F5YvMlmkn5iitL+6dpEPtvxUs=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hqomT1PXqQmnAoiXylI9Xgh4Dkj2BrpYB9g8iSkJIe6tgT/BD9WksDf3rDU8NtR47 AJjCquMW2ox0ozWSixIXFscNs6XpIaexFGlVPhJSzXycaOyl0BNd/1I/miZz8SV4Uf 9dE6pwnrKuTspGq7nwzs6VpLLWur4uSQgUstpn7k= Received: from send243.i.mail.ru (send243.i.mail.ru [95.163.59.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 64B0416E0D7D for ; Sat, 3 Jan 2026 09:04:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 64B0416E0D7D Received: by exim-smtp-7b4fb89df9-hgqz5 with esmtpa (envelope-from ) id 1vbukL-00000000Rni-1eeV; Sat, 03 Jan 2026 09:04:17 +0300 Date: Sat, 3 Jan 2026 09:04:20 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <68126d8ab8cee62099b64e6c5de6f47abfb727f8.1766738771.git.skaplun@tarantool.org> <048f4db3-8757-4630-895d-d226b594d890@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <048f4db3-8757-4630-895d-d226b594d890@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD136B1DE29D0A141801E96C80D96E6DBF182A05F538085040A667A51FFBBD5A573DE06ABAFEAF6705C0D0033CCD51A09A154A738D58A9DE33B76EC74E5D6971C8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE783C1FBFE215D363AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376A27C8034CCD05E58638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2FA7F4050AA1EBC582E070BE324C7D3C41F4EBC6344DAFAF7F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249D082881546D93491CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0A29E2F051442AF778941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C315AF0D0D4FC4FA3D35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5985AFD9E3C52F9C75002B1117B3ED696EFFC076E26111C7C5B6221DB6D7A72AD823CB91A9FED034534781492E4B8EEAD0942DC5495D0595EBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659FF6BB7B0B1F6096CD5810AF6E38F0984367EEC8DE9E91E27208CEB3999C1E2CE604DE098C148C542B8341EE9D5BE9A0A4FF9C29921E213364A1060A1218B8216185762C61F4B72E98CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVTZJppT4ZVHR9EINdJsLOgs= X-DA7885C5: 0B3E35FD66DC8ADDF255D290C0D534F95A1CD3D7A9E512A3434EB5D1BDC7A2E55A1B1B71CFF711D45B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD2D553A85E2DDFDCD0FE2FDBE5055767FA739C7F48425A570BE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 32/41] perf: adjust scimark-sor in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answer below. On 02.01.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with the same comment > > about missed test-specific option in the usage. > > Sergey > > On 12/26/25 12:18, Sergey Kaplun wrote: > > This patch adjusts the aforementioned test to use the benchmark > > framework introduced before. The default arguments are adjusted > > according to the file. The arguments to the script still > > can be provided in the command line run. > > > > Checks are omitted since they were not present in the original suite, > > plus the precise result value depends on the input parameter. > > --- > > perf/LuaJIT-benches/scimark-sor.lua | 20 +++++++++++++++++++- > > 1 file changed, 19 insertions(+), 1 deletion(-) > > > > diff --git a/perf/LuaJIT-benches/scimark-sor.lua b/perf/LuaJIT-benches/scimark-sor.lua > > index e537e986..9bcdb0ad 100644 > > --- a/perf/LuaJIT-benches/scimark-sor.lua > > +++ b/perf/LuaJIT-benches/scimark-sor.lua > > @@ -1 +1,19 @@ > > -require("scimark_lib").SOR(100)(tonumber(arg and arg[1]) or 50000) > > +local bench = require("bench").new(arg) > > + > > +local cycles = tonumber(arg and arg[1]) or 50000 > > + > Do we want to add this option to the usage? I suppose there is no need for it. This still may be done if you are exploring the benchmark behaviour. But you will read its sources in this case anyway. > > +local benchmark > > +benchmark = { > > + name = "scimark_sor", > > + -- XXX: The description of tests for the function is too > > + -- inconvenient. > > + skip_check = true, > > + payload = function() > > + local flops = require("scimark_lib").SOR(100)(cycles) > > + benchmark.items = flops > > + end, > > +} > > + > > +bench:add(benchmark) > > + > > +bench:run_and_report() -- Best regards, Sergey Kaplun