From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B12F816F2A44; Sat, 3 Jan 2026 09:06:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B12F816F2A44 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1767420379; bh=G4UHIX+Td3kYIfWkMwSH6a68c0Fgn6HmIPPVSWyiwbk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=KiEIO9seXBaUOVAkQRKksdgUJ7bVzAGaYJswt4GgnQwWV5RIjessV3zHjwe2lDPr3 3Y0JAyqQxwbxxBXiLBrniR4FX2Ij4DGjNEr7P+DA83RRbaVQ4cgoOrZlYpnIqAjG5g ZStn3aWKv6wrkIYAOGYqU6cwCJcxDa2TrLMcg/Ok= Received: from send149.i.mail.ru (send149.i.mail.ru [89.221.237.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4FF8416F2A44 for ; Sat, 3 Jan 2026 09:06:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4FF8416F2A44 Received: by exim-smtp-7b4fb89df9-j77gv with esmtpa (envelope-from ) id 1vbumH-000000002MD-0aLs; Sat, 03 Jan 2026 09:06:17 +0300 Date: Sat, 3 Jan 2026 09:06:20 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <51be3232be0be26763b2f3cd48d3a44eec0e5516.1766738771.git.skaplun@tarantool.org> <22a540f3-9fe4-470f-b3d5-263fada6b201@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22a540f3-9fe4-470f-b3d5-263fada6b201@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBDBD402C266276CBAD49C55E60069EDAD4182A05F5380850409BE05186D86F5D6A3DE06ABAFEAF6705AF672CF0DF895DB7154A738D58A9DE33954A11D17F55FE80 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E8204D72912C702FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BFD6B3F1638522B88638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B27FF9F42F93E910CA2E070BE324C7D3C4A086C7B0A897924BF6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249D082881546D93491CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0A3E989B1926288338941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3FB9365559B687AC835872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A563E945CE2BD9789C5002B1117B3ED696E07362E05655E68EB91D2EB2DEE3878C823CB91A9FED034534781492E4B8EEADB05233B9BC4759D3 X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65926D93EBA5F5512904CCD0581C1184992C1F33032B44B9330CDC4CECD6B558BCE70124BB7A10803BDB8341EE9D5BE9A0A9239E7A3B3942A33EDB7C7AAA534692188DDE515D46BC50B8CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVTZJppT4ZVHRmyqjQRVAgfo= X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD2437A02CE7484FC8218840D0E9E353B193D1FD4344A95F356E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 30/41] perf: adjust scimark-lu in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answer below. On 02.01.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM > > Sergey > > On 12/26/25 12:18, Sergey Kaplun wrote: > > This patch adjusts the aforementioned test to use the benchmark > > framework introduced before. The default arguments are adjusted > > according to the file. The arguments to the script still > > can be provided in the command line run. > > > > Checks are omitted since they were not present in the original suite, > > plus the precise result value depends on the input parameter. > > --- > > perf/LuaJIT-benches/scimark-lu.lua | 20 +++++++++++++++++++- > > 1 file changed, 19 insertions(+), 1 deletion(-) > > > > diff --git a/perf/LuaJIT-benches/scimark-lu.lua b/perf/LuaJIT-benches/scimark-lu.lua > > index 7636d994..4f521e0b 100644 > > --- a/perf/LuaJIT-benches/scimark-lu.lua > > +++ b/perf/LuaJIT-benches/scimark-lu.lua > > @@ -1 +1,19 @@ > > -require("scimark_lib").LU(100)(tonumber(arg and arg[1]) or 5000) > > +local bench = require("bench").new(arg) > > + > > +local cycles = tonumber(arg and arg[1]) or 5000 > Why this option is absent in usage? I suppose there is no need for it. This still may be done if you are exploring the benchmark behaviour. But you will read its sources in this case anyway. This option is persistent for backward compatibility with the original version. > > + > > +local benchmark > > +benchmark = { > > + name = "scimark_lu", > > + -- XXX: The description of tests for the function is too > > + -- inconvenient. > > + skip_check = true, > > + payload = function() > > + local flops = require("scimark_lib").LU(100)(cycles) > > + benchmark.items = flops > > + end, > > +} > > + > > +bench:add(benchmark) > > + > > +bench:run_and_report() -- Best regards, Sergey Kaplun