From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3AAF716F2A71; Sat, 3 Jan 2026 09:19:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3AAF716F2A71 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1767421199; bh=27v8Uem81orWz3CMsVht/tON7eBcVqlxprg04vbXnyE=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=yo9GY/uIx9WxvbbW+2e9S/IA70iiPja16ZPFKCPyHVb3Qt5CBkHRj3/GX3j3esNHB NDxCHcERKIwhvPRSkSAwuc8rSbek2q6vKkeLK6Co6zKD4WTRT2EixOUDwVIMkU7RRh sn5QxEGZPL9cTWnv2OFKd3t4AGnZEcJUxhiUxV+4= Received: from send241.i.mail.ru (send241.i.mail.ru [95.163.59.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2430C16F2A6F for ; Sat, 3 Jan 2026 09:19:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2430C16F2A6F Received: by exim-smtp-7b4fb89df9-fk75g with esmtpa (envelope-from ) id 1vbuzV-000000009G9-15BS; Sat, 03 Jan 2026 09:19:57 +0300 Date: Sat, 3 Jan 2026 09:20:00 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <137994c89849daa406bc9140cf4d96f5b632e70d.1766738771.git.skaplun@tarantool.org> <6ad35db1-a272-4000-8c08-1b47a04716b7@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ad35db1-a272-4000-8c08-1b47a04716b7@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD826642AD4A534357A371A8F1BADBE128182A05F53808504034FE1C092BF1BD433DE06ABAFEAF6705CBC6069F9E87EAB56F86D3B42967E25D54C85456B1E49444 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77E216A0E97507353EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F88016AB904663428638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2E4AE45B629CC03952E070BE324C7D3C4D357C8B67F5FCF68F6B57BC7E64490618DEB871D839B73339E8FC8737B5C22498424CA1AAF98A6958941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE75A9E79F66F1C28F3731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A585A7DD9CCD9000F05002B1117B3ED6960964F2BE8746D5C41E49B01306B5E3AD823CB91A9FED034534781492E4B8EEADF5E532225D4D775BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65937E6EF800D01DC569288941EA19535AD5F33274E89FF506BDEC91CD0AFE3C8C45761A79185B28EB4B8341EE9D5BE9A0AFBA159A61C22FA0FB3C995AAE39C2A82DCB341F8702EFE218CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVTZJppT4ZVHRlj5bwH+y8H4= X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD29CB07656E6E1993C4E93D247132CAED1872BF0FE7954271BE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 04/41] perf: adjust array3d in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comments, see the iterative patch below. On 29.12.25, Sergey Bronnikov wrote: > Hi, Sergey! > > LGTM with a minor comments. > > Sergey > > On 12/26/25 12:17, Sergey Kaplun wrote: > > -for x,y,z inarr:points() do > > -arr:set(x, y, z, x*x) > > -end > > -assert(arr.image[dim^3-1] == (dim-1)^2) > > +bench:add({ > > + name = "array3d", > > + checker = function(arr) > > + assert(arr.image[dim^3-1] == (dim-1)^2) > Please add more whitespaces. Fixed, see the iterative patch below. > > + return true > > + end, > > + payload = function() > > + local arr = array_new(dim, dim, dim, packed) > > + for x, y, z inarr:points() do > > +arr:set(x, y, z, x*x) > s/x*x/x * x/ Fixed: =================================================================== diff --git a/perf/LuaJIT-benches/array3d.lua b/perf/LuaJIT-benches/array3d.lua index 80562706..d41c564e 100644 --- a/perf/LuaJIT-benches/array3d.lua +++ b/perf/LuaJIT-benches/array3d.lua @@ -59,13 +59,13 @@ local packed = arg and arg[2] == "packed" -- Packed image or flat bench:add({ name = "array3d", checker = function(arr) - assert(arr.image[dim^3-1] == (dim-1)^2) + assert(arr.image[dim ^ 3 - 1] == (dim - 1) ^ 2) return true end, payload = function() local arr = array_new(dim, dim, dim, packed) for x, y, z in arr:points() do - arr:set(x, y, z, x*x) + arr:set(x, y, z, x * x) end return arr end, =================================================================== > > + end > > + return arr > > + end, > > + items = dim * dim * dim, > > + -- Limit the number of iterations to avoid OOM errors for > > + -- non-GC64 builds. > > + iterations = 4, > > +}) > > > > +bench:run_and_report() -- Best regards, Sergey Kaplun