From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 93EA91692D87; Fri, 26 Dec 2025 11:42:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 93EA91692D87 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1766738539; bh=foCfTM9Ld8hPHU86sAjoeazu7q12vUaFzwbGlx9E4eQ=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=IVbR3S+ZuT8AwrWNQJHu1ReNpv4Pxx6CVjijPLQsk2oTEKL+OTfD6HeQ/EwCOQ7PQ 1lCH+NuyqYwDpj/kFO6IqWimFRj1bn5VzTpGgvZkFk9HLAV/8CbBA+V7imWgp54whe 1dNneI+9YCYf2Z7vPNhx0Un+9+/Y5IAUFZRLSIZU= Received: from send240.i.mail.ru (send240.i.mail.ru [95.163.59.79]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AE72A1692D88 for ; Fri, 26 Dec 2025 11:42:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AE72A1692D88 Received: by exim-smtp-7b4fb89df9-9wppm with esmtpa (envelope-from ) id 1vZ3Or-000000002fR-33Za; Fri, 26 Dec 2025 11:42:18 +0300 Date: Fri, 26 Dec 2025 11:42:15 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD74B261A13C49CF1ECC4C442725D8AB97182A05F5380850409E71CC074155E2213DE06ABAFEAF6705D0293475F74F0F5495925BE4019C9994AF99FB5340185B15 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70CF6737295EB4C15EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566657B88B02DF8C869003CE17C8AB545D149509A637D2DEF7AFF920557D2AAF3B9389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE778B471BB9634AD8A731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A58BB26648AD495CF35002B1117B3ED696CC138F8D17CD6167250A03108B67251B823CB91A9FED034534781492E4B8EEADDFC043C56F70D752BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6594FF1E62FEA28D1D59F97EAD44D68D7226B6D3BC5451C8BD23F6D9E7E000972461908AE09563AEA25B8341EE9D5BE9A0A7DC58F597236B8662CC415D3122CD98A921D9760842A7BE68CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdtTL5f5BIXbZBu3Brzobtg= X-DA7885C5: 9BC93BA89DE05B48F255D290C0D534F9F4F8C95D67DE7A384875D5A1C598AD3D3364DE2CE83B3F6A5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD224121BE4E72066715CE011D79B4EA7E24FD97D7D3417912DE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 40/41] perf: provide CMake option to setup the benchmark X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review. Please, consider my answers below. On 18.11.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! See my comments. > > Sergey > > On 10/24/25 14:00, Sergey Kaplun wrote: > > This patch introduces the `LUAJIT_BENCH_INIT` option to determine the > > it is actually a runner for benchmark, not a command that runs before > the benchmark itself. > > Please rephrase. Rephrased as discussed offline. > > > I would rename a cmake option appropriately. > LUAJIT_BENCH_EXEC/LUAJIT_BENCH_RUNNER? I prefer to leave it as is to be consistent with namings in tests. > > Feel free to keep as is, I don't insist. > > > shell command to be run before the benchmark itself. It may be useful to > > set taskset, etc. > > --- The updated commit message is the following: | perf: provide CMake option to setup the benchmark | | This patch introduces the `LUAJIT_BENCH_INIT` option to determine the | shell command prefix to be run before the benchmark itself. It may be | useful to set taskset, etc. > > perf/CMakeLists.txt | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/perf/CMakeLists.txt b/perf/CMakeLists.txt > > index 68e561fd..c315597f 100644 > > --- a/perf/CMakeLists.txt > > +++ b/perf/CMakeLists.txt > > @@ -7,6 +7,13 @@ if(CMAKE_BUILD_TYPE STREQUAL "Debug") > > "Timings may be affected.") > > endif() > > > > +# The shell command needs to be run before benchmarks are started. > > +if(LUAJIT_BENCH_INIT) > > + message(STATUS > > + "The following command will run before benchmarks: '${LUAJIT_BENCH_INIT}'." > > + ) > > +endif() > this message is not necessary, one can see it in "ctest -V" output I suppose it is good to mention it in the configuration phase as well. -- Best regards, Sergey Kaplun