From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 25E3C16AE27C; Fri, 26 Dec 2025 11:41:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 25E3C16AE27C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1766738500; bh=LGgqcnPV+nliZUVp9Gjs/zCCiPLjVx6O4KFoqdOIfz8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hnD+sYUZxhCGCN+M5ERt+55tYE33cCvcE8rJK1+PBVFqF86eQ9XL5xBPN1wE4a0bb ocrRPFzBV0kZxF9pEyOZP8i0wWmzql9hPl5KjBjSJWf5MRkn5Lj5G2dobqDfW/dciu 7M502WDrnSQrJyZfuHmWqr/P6Zh7Gm6ohdWGf+so= Received: from send37.i.mail.ru (send37.i.mail.ru [89.221.237.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EE4C116ADBB3 for ; Fri, 26 Dec 2025 11:41:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EE4C116ADBB3 Received: by exim-smtp-7b4fb89df9-vgg5w with esmtpa (envelope-from ) id 1vZ3OD-00000000Jdu-48u9; Fri, 26 Dec 2025 11:41:38 +0300 Date: Fri, 26 Dec 2025 11:41:35 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <3a4e3c46-12d2-41bc-b1ee-12c83aa15cec@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a4e3c46-12d2-41bc-b1ee-12c83aa15cec@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD390EF5E93CD1F77387498C0EC589AA68182A05F5380850404779DFA3330F3F0D3DE06ABAFEAF6705C015410A6397BD3595925BE4019C99943E3E97FC8DFF7329 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F1942E6D70B4A2F0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566657B88B02DF8C8696F0AAED91EBD2234CC1C1C825DF9F3A10D1A2B20BC54DCCB389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE778B471BB9634AD8A731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A51477908483EDE12F5002B1117B3ED6963BA86009D9ED3B81559C6C5561145D6F823CB91A9FED034534781492E4B8EEADA3A806F356AF31D6 X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659773FAB74CC8F6C5E877D6057C7BB06144C64A1272666CD98A1D24168F2164961EA16781867B36EF5B8341EE9D5BE9A0AB5393D6652ED52A26C7459AE02CDBCA17E255B7BC635BE4B8CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdtTL5f5BIXbU/rCZN+gVAQ= X-DA7885C5: FB33D464DC5FCE1CF255D290C0D534F9D0E5DB07AB77FA6B519524B3A3442FBAA029CF8C42546B8E5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD2033718E34BF2FC0557CBC060FB171BB5A16B033DB4C6D4D5E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 39/41] perf: add a script for the environment setup X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review. Please, consider my answers below. On 18.11.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! See my comments. > > Sergey > > On 10/24/25 14:00, Sergey Kaplun wrote: > > The patch adds a script for setting the environment before running > > performance tests. Most of the settings are taken from the Tarantool's > > wiki page dedicated to the benchmarking [1]. > > Honestly, I don't like that we have similar files in two repositories > (aggregate, setup-env.sh). The file is different due to different libraries available. Also, it has its own logic of scanning of directories. may be updated too with time independently between the repositories, since Tarantool and LuaJIT may require the different setup. > > This makes maintenance more complicated. I would put these files to a > shared repository No. It isn't a good approach. As we discussed a thousand times with Igor before, there is no need in the third-party dependency for this repository, it should be self-sufficient. Trust me, you don't want to investigate some regression in the performance testing results because somebody updated a third-party repository. This is why we have the our own tap module for the suite. As you can see, we have zero problems with it. Also, considering my comment above. > > and reuse it for tarantool and luajit repos. > > Original files are even not specified in commit messages for > setup-env.sh and aggregate.lua, Mentioned that this file was taken from the Tarantool repository in the commit message. > > I think it is worth it. No sense to review these files if it was already > done previously. It is good to check that I didn't mess-up the content by accident, anyway. > > > > > [1]:https://github.com/tarantool/tarantool/wiki/Benchmarking > > --- The updated commit message is the following: | perf: add a script for the environment setup | | The patch adds a script for setting the environment before running | performance tests. The script originated from the Tarantool's repository | [2]. Most of the settings are taken from the Tarantool's wiki page | dedicated to the benchmarking [1]. | | [1]: https://github.com/tarantool/tarantool/blob/dcdb3ee83b3d6324011e704b5a3f4ee3e19bbf47/perf/tools/setup_env.sh | [2]: https://github.com/tarantool/tarantool/wiki/Benchmarking -- Best regards, Sergey Kaplun