From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3D6CB16ADB84; Fri, 26 Dec 2025 11:37:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3D6CB16ADB84 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1766738230; bh=u3SLpgIZklOi2CyYIInZhbV//j+aaLyaiYjJK1SyLns=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=rVFyHFswcqFe2e4nELG8Ws+d9B1qOKFDxtE2B5jBcmKK3e2Xl9mXm6pt6kH/SbX+E NyXww4kCedh9Z/RBkbjxk4zpjTPqIrVF2v73oB8YrrhHmbhDvSHfOR6NVr/kdFm7/x MJUszW3hmYC6kY5P4I3ZF2tKAYTxhRumvwEhVweQ= Received: from send80.i.mail.ru (send80.i.mail.ru [89.221.237.175]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D911C16ADBA4 for ; Fri, 26 Dec 2025 11:37:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D911C16ADBA4 Received: by exim-smtp-7b4fb89df9-5mc8r with esmtpa (envelope-from ) id 1vZ3Jr-000000005wg-3hO6; Fri, 26 Dec 2025 11:37:08 +0300 Date: Fri, 26 Dec 2025 11:37:05 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <1a8a820fc79739ef091e7fbd3f127313f12785a1.1761301736.git.skaplun@tarantool.org> <4e47b061-e62e-4f77-8856-b23fd5bfa6b5@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e47b061-e62e-4f77-8856-b23fd5bfa6b5@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD9A7AA89612843F49E05A58644225EC05182A05F53808504004BF7085C53AFB553DE06ABAFEAF6705FEFF4498D77B1D1995925BE4019C99946BFCBEEFC207F92E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE712EB008F780777E9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566657B88B02DF8C8694D2507B1BA4A7CAF53B66FCEDA1AA2E19CAA903A57564670389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3C9EEE74C166EF7BC35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A537FE3CF640FECEA35002B1117B3ED69657C5AD6F2B6C818F7E0012C66AE17B00823CB91A9FED034534781492E4B8EEAD09122B91796FF21FBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659CB331EC1CC521561BCC67893032DC467B0BD75E21AF12B650F445155661773E007BC8E7112C33E55B8341EE9D5BE9A0AB7C19CA4239FFB06AB3BEA52DD46254FA01EE314E8765FAA8CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdtTL5f5BIXbMIlBdqBSjno= X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD2CFBA232FB22CDB46D4FC071BC180CD004BF537666E3EAF61E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 34/41] perf: adjust series in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review. Please, consider my answers below. On 17.11.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! See comments below. > > Sergey > > On 10/24/25 14:00, Sergey Kaplun wrote: > > This patch adjusts the aforementioned test to use the benchmark > > framework introduced before. The default arguments are adjusted > > according to the file. The arguments to the script still > > can be provided in the command line run. > > --- > > perf/LuaJIT-benches/series.lua | 20 ++++++++++++++------ > > 1 file changed, 14 insertions(+), 6 deletions(-) > > > > diff --git a/perf/LuaJIT-benches/series.lua b/perf/LuaJIT-benches/series.lua > > index f766cb32..3dc970c5 100644 > > --- a/perf/LuaJIT-benches/series.lua > > +++ b/perf/LuaJIT-benches/series.lua Added the comment with the short benchmark description, as we discussed offline: =================================================================== diff --git a/perf/LuaJIT-benches/series.lua b/perf/LuaJIT-benches/series.lua index 3dc970c5..56f012b7 100644 --- a/perf/LuaJIT-benches/series.lua +++ b/perf/LuaJIT-benches/series.lua @@ -1,3 +1,7 @@ +-- The benchmark to check the performance of FP arithmetics, power +-- operation, and trigonometrical functions. Calculates the +-- integrals of sin/cos functions. + local bench = require("bench").new(arg) local function integrate(x0, x1, nsteps, omegan, f) =================================================================== > > @@ -1,3 +1,4 @@ > > +local bench = require("bench").new(arg) > > > > local function integrate(x0, x1, nsteps, omegan, f) > > local x, dx = x0, (x1-x0)/nsteps > > @@ -26,9 +27,16 @@ local function series(n) > > end > > > > local n = tonumber(arg and arg[1]) or 10000 > > -local tm = os.clock() > > -local t = series(n) > > -tm = os.clock() - tm > > -assert(math.abs(t[1]-2.87295) < 0.00001) > > -io.write(string.format("size %d, %.2f s, %.1f iterations/s\n", > > - n, tm, (2*n-1)/tm)) > debug print was lost, is it intentional? It is not the debug print, but rather the information about the benchmark performance. We collect this stat automatically by the bench module. > > + > > +bench:add({ > > + name = "series", > > + checker = function(res) > > + return math.abs(res[1]-2.87295) < 0.00001 > add more whitespaces Added: =================================================================== diff --git a/perf/LuaJIT-benches/series.lua b/perf/LuaJIT-benches/series.lua index 3dc970c5..16d34fdf 100644 --- a/perf/LuaJIT-benches/series.lua +++ b/perf/LuaJIT-benches/series.lua @@ -31,7 +31,7 @@ local n = tonumber(arg and arg[1]) or 10000 bench:add({ name = "series", checker = function(res) - return math.abs(res[1]-2.87295) < 0.00001 + return math.abs(res[1] - 2.87295) < 0.00001 end, payload = function() return series(n) =================================================================== > > + end, > > + payload = function() > > + return series(n) > > + end, > > + items = 2 * n - 1, > > +}) > > + > > +bench:run_and_report() -- Best regards, Sergey Kaplun