From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B1B2516AE257; Fri, 26 Dec 2025 11:33:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B1B2516AE257 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1766738001; bh=sq1RZs8TMHarIq+2wydicBolYpDuToVXEmuiSQGSL/Y=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hnUUruSM/uhio/wT0+CdtwtC5P5hd1wO3But9dggwWT2XKjCajjdCcS04pqmIX917 sZfzg8lB6T9MMxnvSbTFMm4/OIvOFsYPQ4zUs+taWM1t6WSWBo61HLeVc/d2iUtSBB DgShjVotENNcuDDuDzKI7/X+0fKpOVFr+gfVSBlI= Received: from send105.i.mail.ru (send105.i.mail.ru [89.221.237.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6561016AE25D for ; Fri, 26 Dec 2025 11:33:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6561016AE25D Received: by exim-smtp-7b4fb89df9-pmfc6 with esmtpa (envelope-from ) id 1vZ3GB-00000000MNC-1i7l; Fri, 26 Dec 2025 11:33:19 +0300 Date: Fri, 26 Dec 2025 11:33:17 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <26004ca1-a817-4c52-9be9-07fb55197dd4@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26004ca1-a817-4c52-9be9-07fb55197dd4@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD915529E8FC4AA0671CA1E07C573811262D4DDCA1B9C9DBAFD1867C24CE74E72BB5FE18E9CBFBE7C079B2EC8A0D1EEF251D1BD2E8F7283065D509EEC42417178CF68D4D13513A1636624DAF05A372A3159 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F68DA2F3749BB650EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F88016AB904663428638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2F7830D41506041B92E070BE324C7D3C4D62C63A82AC0389DF6B57BC7E64490618DEB871D839B73339E8FC8737B5C22498424CA1AAF98A6958941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE76D0F27F7E6A6C418731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A58CAB1D50779A911E5002B1117B3ED6965FCBA00ED18DAD64D57BAD45EC4C5DE1823CB91A9FED034534781492E4B8EEAD5E90D3DD2A5B7EAFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6595B6FFC69301072C39B0C4DAA1DF642E3BC76DE219D482D7EE253AA16BE3D14BB5A52806C2F080FD7B8341EE9D5BE9A0AA23934115EEA07909409709379B3BBDB6543B6F0080796FF8CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdtTL5f5BIXb4/fwvPR/DFw= X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD2941826E0924A482494C4A20CD4E9E1CC0D55BCE8D380EEA4E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 29/41] perf: adjust scimark-fft in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review. Please, consider my answers below. On 17.11.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! Please see my comments. > > Sergey > > On 10/24/25 13:50, Sergey Kaplun wrote: > > This patch adjusts the aforementioned test to use the benchmark > > framework introduced before. The default arguments are adjusted > > according to the file. The arguments to the script still > > can be provided in the command line run. > > > > Checks are omitted since they were not present in the original suite, > > plus the precise result value depends on the input parameter. > > --- > > perf/LuaJIT-benches/scimark-fft.lua | 19 ++++++++++++++++++- > > 1 file changed, 18 insertions(+), 1 deletion(-) > > > > diff --git a/perf/LuaJIT-benches/scimark-fft.lua b/perf/LuaJIT-benches/scimark-fft.lua > > index c05bb69a..96535774 100644 > > --- a/perf/LuaJIT-benches/scimark-fft.lua > > +++ b/perf/LuaJIT-benches/scimark-fft.lua > > @@ -1 +1,18 @@ > > -require("scimark_lib").FFT(1024)(tonumber(arg and arg[1]) or 50000) > > +local bench = require("bench").new(arg) > > + > > +local cycles = tonumber(arg and arg[1]) or 50000 > Why 50000? It is the default for x86 arch. I've taken the values from PARAMS_x86, since this is the most important architecture for the Tarantool, see the commit message. Also, it is the same as before the patch. > > +local benchmark > > +benchmark = { > > + name = "scimark_fft", > > + -- XXX: The description of tests for the function is too > > + -- inconvenient. > > + skip_check = true, > > + payload = function() > > + local flops = require("scimark_lib").FFT(1024)(cycles) > Why 1024? It is the same as before the patch. This constant is the same as in the original SciMark v2 benchmark. > > + benchmark.items = flops > > + end, > > +} > > + > > +bench:add(benchmark) > > + > > +bench:run_and_report() -- Best regards, Sergey Kaplun