From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 47E7116AE26E; Fri, 26 Dec 2025 11:32:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 47E7116AE26E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1766737967; bh=H3loduBXQ7ux1Xr3CCq4JoRq4DZXhdINRNskyMLixWk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=jN0+qC5js90wxkXiTa5pzvHxnEbnh4m0H+GkrFk+a/OyiTPgTwlvHKiSxy+HxGID5 Rxy++hSwC0sPadqmB2+VVjEWeX3TQ81tfwsiQYbsbnI+mN9J1mmGdQK+yfJDTV1Le4 H1zT3Xw+bLarjANX+Oc0//wMs1ZGRCG1tZzsRgf8= Received: from send196.i.mail.ru (send196.i.mail.ru [95.163.59.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8946716AE257 for ; Fri, 26 Dec 2025 11:32:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8946716AE257 Received: by exim-smtp-7b4fb89df9-8zdd6 with esmtpa (envelope-from ) id 1vZ3Fd-000000006tI-0m6X; Fri, 26 Dec 2025 11:32:45 +0300 Date: Fri, 26 Dec 2025 11:32:43 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <14b84914b1eb1b2a1b0bf934894191aee0973443.1761301736.git.skaplun@tarantool.org> <964e4d40-4c62-4a97-b487-050187c6900a@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <964e4d40-4c62-4a97-b487-050187c6900a@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD651A111AECFA267DF4E9497E9DD4D3AA182A05F53808504003F93E08B927DFE43DE06ABAFEAF67057463126CD7F8EA6AC3CE4153D521EAFEDEB700F1740BDFE9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE752E71F0C64B7C834EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371D5B197C6EC5B4BE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2DFF6C8E6478B75672E070BE324C7D3C4C31A26EB98E2BA73F6B57BC7E64490618DEB871D839B73339E8FC8737B5C224936DA1BED736F9328CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C078FCF50C7EAF9C588941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3C9EEE74C166EF7BC35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A588032AB4F53353265002B1117B3ED6961A8DCB5D136729DF886DC9BC01168B20823CB91A9FED034534781492E4B8EEAD5DF1C2DF01CE7211BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6596B8EAE1F3EFBBC490144B2D6BA808E3D5526B2DB4EC26ABD87FACAD9B683F98717CB566600326108B8341EE9D5BE9A0A5DE057FD4EB9450ADC25F6D63C950B093D55D06194DA2BFB8CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdtTL5f5BIXb3NLxva6rHA4= X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD23391AF346B5F3388ABD831B3DAFA47F4DA85F736DEBB8376E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 28/41] perf: move to directory X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review. Please, consider my answers below. On 17.11.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with a minor comment: > > I propose to squash this patch with patch "perf: add CMake infrastructure" I prefer to leave it as is to make diff clear. > > or add to the commit message "Needed for ...". Needed for is used for the ticket mentioning. There is no ticket about this, so ignoring. The commit message contains the rationale. The patch itself was done in this order before refactoring the scimark-*.lua benchmarks, so I prefer to leave it as is. > > Sergey > > On 10/24/25 13:50, Sergey Kaplun wrote: > > This helps to avoid this library in the scanning of the test files > > for the suite. > > --- > > perf/LuaJIT-benches/{ => libs}/scimark_lib.lua | 0 > > 1 file changed, 0 insertions(+), 0 deletions(-) > > rename perf/LuaJIT-benches/{ => libs}/scimark_lib.lua (100%) > > > > diff --git a/perf/LuaJIT-benches/scimark_lib.lua b/perf/LuaJIT-benches/libs/scimark_lib.lua > > similarity index 100% > > rename from perf/LuaJIT-benches/scimark_lib.lua > > rename to perf/LuaJIT-benches/libs/scimark_lib.lua -- Best regards, Sergey Kaplun