From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DB71A16AE262; Fri, 26 Dec 2025 11:30:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DB71A16AE262 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1766737846; bh=rkVs88W+W3ALs07cLROkvlo5DHpNJxAupx7HFJFvJQc=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=RswDJ6+lUgle4qHCEnOeQnzi/Sjeq8bfv2Cxne6fDyb7p3/nK27USGgdUrXAmiQMq DitASvVCkvi4MuhMy7yX7bIbVBoGV+lAZqgS06Hw/9aex8auCALiJ/2jbOgfNAvQys 8cPz9jCSkbHL6OzAnLf9L1QCHbVn3ltBROVVxCxE= Received: from send83.i.mail.ru (send83.i.mail.ru [89.221.237.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EC95216AE261 for ; Fri, 26 Dec 2025 11:30:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EC95216AE261 Received: by exim-smtp-7b4fb89df9-4rqsk with esmtpa (envelope-from ) id 1vZ3De-000000008Kj-42Eh; Fri, 26 Dec 2025 11:30:43 +0300 Date: Fri, 26 Dec 2025 11:30:40 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <6afff7d5f3be90f8c346ccbd42db20269cad8c1f.1761301736.git.skaplun@tarantool.org> <0bee5954-c6f6-47e7-8ec4-50dd323792ba@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0bee5954-c6f6-47e7-8ec4-50dd323792ba@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBDD803ECE58504FBFD117E6A90C4FE9736182A05F538085040C4FE5090A40120AB3DE06ABAFEAF6705E1E8BDE7DBBEECE7C3CE4153D521EAFE28D9CF984B353DE0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7484B509D84968742EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566657B88B02DF8C8693B3B752A53FB2DEC838F8FA37CF8B9EAB53E4AD9E5A998AD389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE76D0F27F7E6A6C418731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5FA38BAB09BF27DBE5002B1117B3ED6967D3CEFD2ECED404A8B25839F35DFE037823CB91A9FED034534781492E4B8EEAD887A4342A344B6EDBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6596E2DCF6322D581372BF628CAA5C98D7B3B0A57E3B5E0E8AA1A48338DB05B99D46ADC59C6FAFFFDEFB8341EE9D5BE9A0A4B502218B516D65FF9E44AC996F9E2CCCCF7AD42537673F88CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdtTL5f5BIXb1bnwxt1J7o8= X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD27EA0197FB975C7C312406894FAA6102DCA4A799C9E0A38A3E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 25/41] perf: adjust recursive-fib in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review. Please, consider my answers below. On 17.11.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! See my comments. > > Sergey > > On 10/24/25 13:50, Sergey Kaplun wrote: > > This patch adjusts the aforementioned test to use the benchmark > > framework introduced before. The default arguments are adjusted > > according to the file. The arguments to the script still > > can be provided in the command line run. > > --- > > perf/LuaJIT-benches/recursive-fib.lua | 28 +++++++++++++++++++++++++-- > > 1 file changed, 26 insertions(+), 2 deletions(-) > > > > diff --git a/perf/LuaJIT-benches/recursive-fib.lua b/perf/LuaJIT-benches/recursive-fib.lua > > index ef9950de..99af3f9e 100644 > > --- a/perf/LuaJIT-benches/recursive-fib.lua > > +++ b/perf/LuaJIT-benches/recursive-fib.lua > > @@ -1,7 +1,31 @@ Added the comment with the short benchmark description, as we discussed offline: =================================================================== diff --git a/perf/LuaJIT-benches/recursive-fib.lua b/perf/LuaJIT-benches/recursive-fib.lua index 99af3f9e..8e96934a 100644 --- a/perf/LuaJIT-benches/recursive-fib.lua +++ b/perf/LuaJIT-benches/recursive-fib.lua @@ -1,3 +1,8 @@ +-- The benchmark to check the performance of recursive calls. +-- Calculates the Fibonacci values recursively. +-- For the details see: +-- http://mathworld.wolfram.com/FibonacciNumber.html + local bench = require("bench").new(arg) local function fib(n) =================================================================== > > +local bench = require("bench").new(arg) > > + > > local function fib(n) > > if n < 2 then return 1 end > > return fib(n-2) + fib(n-1) > > end > > > > -local n = tonumber(arg[1]) or 10 > > -io.write(string.format("Fib(%d): %d\n", n, fib(n))) > debug print was lost, is it intentional? It is not the debug print, but verification of program correctness, also it prevents DCE by the compilers in the compiled languages. Here it is tested by the checker function. > > +local n = tonumber(arg[1]) or 40 > Why 40? It is the default for x86 arch. I've taken the values from PARAMS_x86, since this is the most important architecture for the Tarantool, see the commit message. > > + -- Best regards, Sergey Kaplun