From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DD43A1679236; Fri, 26 Dec 2025 11:25:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DD43A1679236 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1766737556; bh=JvAknlkgXsuEoTwqpGpzuNQEjyPEnDaK6QsvqtJqJg0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AHoEN6THJgygd+7um2ZeCbgketmDsw3HXwB7tNTyWQHrq/PNqqjgo6+pczDKKN9Wv yGVEECCRCIvjpox2OfhPr0E8uhKDBWQEZJuQ/GFbzYmWb6O0f69PBbVO4PCUFYHtMh TLLoKgwqBp1lMfA4t0t7RMyQzp34QkrKyTuaxIaQ= Received: from send240.i.mail.ru (send240.i.mail.ru [95.163.59.79]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1A28E167922F for ; Fri, 26 Dec 2025 11:25:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1A28E167922F Received: by exim-smtp-7b4fb89df9-dkm8m with esmtpa (envelope-from ) id 1vZ38x-00000000EB9-43ko; Fri, 26 Dec 2025 11:25:52 +0300 Date: Fri, 26 Dec 2025 11:25:49 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <32f0c04e390b756cae707eb3476a70f31b255357.1761301736.git.skaplun@tarantool.org> <5a2fed25-7350-4b69-bdad-a3a7a73ee637@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a2fed25-7350-4b69-bdad-a3a7a73ee637@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD826642AD4A5343575326B9AFFB3FD97C182A05F538085040E586F0F62C1AF7663DE06ABAFEAF6705E13D3882204488F1C3CE4153D521EAFE3DA8AF4631D2EE55 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7466896EF24E80F12EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566657B88B02DF8C869B10D6B56D023FFEBA78717A9BEE3F4878C1011F9143DE6DD389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE76D0F27F7E6A6C418731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5E1011BDFD34D68E35002B1117B3ED696BA16F214C1A95B129E040399BDE4761E823CB91A9FED034534781492E4B8EEAD09122B91796FF21FBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6594ADDE861006BFD3F728ECCA74AC48107F7FFF0C2096860A46BB73D5E464C3321421B2A1C643C9A17B8341EE9D5BE9A0AF456532E32B18314A090E7FE45C09815EF5CF9E987DD57418CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdtTL5f5BIXbklg62OOnojo= X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD2FC73C2D761713E3C548A4D63727F1F397FA6D962E0024709E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 19/41] perf: adjust nsieve-bit in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! See my answers below. On 17.11.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! > > Sergey > > On 10/24/25 13:50, Sergey Kaplun wrote: > > This patch adjusts the aforementioned test to use the benchmark > > framework introduced before. The default arguments are adjusted > > according to the file. The arguments to the script still > > can be provided in the command line run. > > --- > > perf/LuaJIT-benches/nsieve-bit.lua | 35 +++++++++++++++++++++++++----- > > 1 file changed, 30 insertions(+), 5 deletions(-) > > > > diff --git a/perf/LuaJIT-benches/nsieve-bit.lua b/perf/LuaJIT-benches/nsieve-bit.lua > > index 820a3726..4858e9e2 100644 > > --- a/perf/LuaJIT-benches/nsieve-bit.lua > > +++ b/perf/LuaJIT-benches/nsieve-bit.lua > > @@ -1,3 +1,4 @@ Added the comment with the short benchmark description, as we discussed offline: =================================================================== diff --git a/perf/LuaJIT-benches/nsieve-bit.lua b/perf/LuaJIT-benches/nsieve-bit.lua index e2c6f52c..dd85dad5 100644 --- a/perf/LuaJIT-benches/nsieve-bit.lua +++ b/perf/LuaJIT-benches/nsieve-bit.lua @@ -1,3 +1,9 @@ +-- Benchmark to check the performance of bitwise arithmetics and +-- access to the array structure. This benchmark finds all prime +-- numbers in a given segment. This is the bit variation. +-- For the details see: +-- https://en.wikipedia.org/wiki/Sieve_of_Eratosthenes + local bench = require("bench").new(arg) local bit = require("bit") =================================================================== > > +local bench = require("bench").new(arg) > > > > local bit = require("bit") > > local band, bxor, rshift, rol = bit.band, bit.bxor, bit.rshift, bit.rol > > @@ -17,11 +18,35 @@ local function nsieve(p, m) > > return count > > end > > > > -local N = tonumber(arg and arg[1]) or 1 > > +local DEFAULT_N = 12 > Why 12? It is the default for x86 arch. I've taken the values from PARAMS_x86, since this is the most important architecture for the Tarantool, see the commit message. > > +local N = tonumber(arg and arg[1]) or DEFAULT_N > > if N < 2 then N = 2 end > > local primes = {} > > > > -for i=0,2 do > add more whitespaces, here and below This is removed line, fixed in the corresponding added line. > > - local m = (2^(N-i))*10000 > > - io.write(string.format("Primes up to %8d %8d\n", m, nsieve(primes, m))) > io.write is lost, is it intentional? Yes, it is checked via the checker function. > > -end > > +local benchmark > > +benchmark = { > > + name = "nsieve_bit", > > + payload = function() > > + local res = {} > > + local items = 0 > > + for i=0,2 do > > + local m = (2^(N-i))*10000 > add more whitespaces Fixed. =================================================================== diff --git a/perf/LuaJIT-benches/nsieve-bit.lua b/perf/LuaJIT-benches/nsieve-bit.lua index 4858e9e2..e2c6f52c 100644 --- a/perf/LuaJIT-benches/nsieve-bit.lua +++ b/perf/LuaJIT-benches/nsieve-bit.lua @@ -29,8 +29,8 @@ benchmark = { payload = function() local res = {} local items = 0 - for i=0,2 do - local m = (2^(N-i))*10000 + for i = 0, 2 do + local m = (2 ^ (N - i)) * 10000 items = items + m res[i] = nsieve(primes, m) end =================================================================== > > + items = items + m -- Best regards, Sergey Kaplun