From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5868D16B02FA; Fri, 26 Dec 2025 11:19:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5868D16B02FA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1766737145; bh=u7jTPBM+IDx2TZqNLgaU9vgH8QQG74Ey0Og7HMXWWeM=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=dG0KQiIYTmbBARMdZjpsfoll1sWwA1Af6SNcAZwfttSrO6h7rgogKjSDDCVC21ZPA bIn3Z9wKY94AdoCnYdPkGam/bIujDNmITIfiPz6lljwy7rFt2dlTT1qPNLJcW86rHo 4r7Tm9g9p3YjchZtpNb2pMEKmlrfqNiUbkrpPzZQ= Received: from send83.i.mail.ru (send83.i.mail.ru [89.221.237.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3E1FC16B02F9 for ; Fri, 26 Dec 2025 11:19:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3E1FC16B02F9 Received: by exim-smtp-7b4fb89df9-tpgcx with esmtpa (envelope-from ) id 1vZ32M-00000000L5t-0UOm; Fri, 26 Dec 2025 11:19:02 +0300 Date: Fri, 26 Dec 2025 11:18:59 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <75a84e56bcbe64c8628c40633819b5314129788d.1761301736.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD826642AD4A5343575326B9AFFB3FD97C182A05F538085040C7C1FFAB0339B9823DE06ABAFEAF6705815DE4B1D2F224E9C3CE4153D521EAFED24D1EEE1A9971A2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72424932217190DC2EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566657B88B02DF8C8698DA6E8D42BADF361EE4AB7E3D821376AE548E9AC22FB2BC3389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE76D0F27F7E6A6C418731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A538B2340EC4C0F2BD5002B1117B3ED69688B5359982EC17F933EE06AFCD964888823CB91A9FED034534781492E4B8EEAD09122B91796FF21FBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6593D2AD9A81F950073BA2E41225E0B14D02C507E8090D30711151063D3B100428EB3B2CC26526FD512B8341EE9D5BE9A0AF339DE02596112A709374FF75324713193628D6D3070EA2B8CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdtTL5f5BIXbPQtwMiJrY4I= X-DA7885C5: 48624409F8A5A514F255D290C0D534F93BE4E6EBD27C014BE8066B29798FFDEF9EE40F74992EF4645B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD221BD37591BFBDB50FAC896E59400F35395A99181BE7EC5D9E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 12/41] perf: adjust life in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answers below. On 17.11.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! See my comments. > > Sergey > > On 10/24/25 13:50, Sergey Kaplun wrote: > > This patch adjusts the aforementioned test to use the benchmark > > framework introduced before. The default arguments are adjusted > > according to the file. > > > > The output is redirected to /dev/null. The checker tests the result > > after the exact amount of iterations for the fixed field (as it is > > declared in the original benchmark). > > --- > > perf/LuaJIT-benches/life.lua | 79 +++++++++++++++++++++++++++++++++++- > > 1 file changed, 78 insertions(+), 1 deletion(-) > > > > diff --git a/perf/LuaJIT-benches/life.lua b/perf/LuaJIT-benches/life.lua > > index 911d9fe1..d0e4dc98 100644 > > --- a/perf/LuaJIT-benches/life.lua > > +++ b/perf/LuaJIT-benches/life.lua Added the comment with the short benchmark description, as we discussed offline: =================================================================== diff --git a/perf/LuaJIT-benches/life.lua b/perf/LuaJIT-benches/life.lua index 5a316364..dbf26fac 100644 --- a/perf/LuaJIT-benches/life.lua +++ b/perf/LuaJIT-benches/life.lua @@ -1,5 +1,12 @@ -- life.lua --- original by Dave Bollinger posted to lua-l +-- The benchmark to check the performance of array-like data +-- structures with RW access. John Horton Conway's "Game of Life" +-- cellular automaton. +-- For the details see: +-- https://en.wikipedia.org/wiki/Conway%27s_Game_of_Life +-- Original by Dave Bollinger posted +-- to lua-l: +-- http://lua-users.org/lists/lua-l/1999-12/msg00003.html -- modified to use ANSI terminal escape sequences -- modified to use for instead of while =================================================================== > > @@ -3,6 +3,8 @@ > > -- modified to use ANSI terminal escape sequences > > -- modified to use for instead of while > > > > +local bench = require('bench').new(arg) > > + > > local write=io.write > > > > ALIVE="�" DEAD="�" > We usually use ascii only symbols. Should we replace with ascii-only > alternative? OK, removed, since we already have the mentioning of the modification in the test header and it can't affect the performance somehow. =================================================================== diff --git a/perf/LuaJIT-benches/life.lua b/perf/LuaJIT-benches/life.lua index d0e4dc98..5a316364 100644 --- a/perf/LuaJIT-benches/life.lua +++ b/perf/LuaJIT-benches/life.lua @@ -7,7 +7,6 @@ local bench = require('bench').new(arg) local write=io.write -ALIVE="¥" DEAD="þ" ALIVE="O" DEAD="-" function delay() -- NOTE: SYSTEM-DEPENDENT, adjust as necessary =================================================================== > > @@ -106,6 +108,81 @@ function LIFE(w,h) > > if gen>2000 then break end > > --delay() -- no delay > dead code What do you mean about dead code? If you are suggesting to delete the `delay()` function, I prefer not to do it in case we want to debug the behaviour somehow. Also, this adds additional GC objects related to the `delay()` function and its proto (it is not much, but anyway). Also, this comment helps to understand where the delay function should be emitted if necessary. I prefer avoiding the modification of the code that is not vital. Also, this part isn't modified, so I prefer to leave it as is. > > end > > + return thisgen > > end > > > > -LIFE(40,20) -- Best regards, Sergey Kaplun