From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 25CDA169C806; Fri, 26 Dec 2025 11:04:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 25CDA169C806 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1766736296; bh=PvovlzeuBqwXr1eYuq46lCZfIpd4Pxxdd0m/j1PWLN8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=o3ad8bEXMGecZXPlTqop8Fzc1bJ5F3s7cogVjQC7Ob+SgpnfuSHkd0BVtGQniSiQB Y6QlhR7FiP4/wDHtjnOVNOlZOl4A2RRynIyReHYialbjZ2UfdbTDTGj/Xy4AnbH/qT pPJlPf7DucENcz1VCtjal+6N/sGrAyYBjkk/Sw3E= Received: from send173.i.mail.ru (send173.i.mail.ru [95.163.59.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A8B144E3D7D for ; Fri, 26 Dec 2025 11:04:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A8B144E3D7D Received: by exim-smtp-7b4fb89df9-jfx52 with esmtpa (envelope-from ) id 1vZ2of-000000003yF-1uSx; Fri, 26 Dec 2025 11:04:53 +0300 Date: Fri, 26 Dec 2025 11:04:51 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <830ad4e2-f321-49bf-8079-06c4b5b43795@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <830ad4e2-f321-49bf-8079-06c4b5b43795@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD136B1DE29D0A14186819F7335A1BEA2E182A05F5380850407429E9DD7D73DFEB3DE06ABAFEAF6705BDBB84EE75468AE54F327FDBBEDA3D812031A3DD069C1E5A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566657B88B02DF8C86993AB9A6C6D5BC906AA3EC2B658391A9024B1E34AEE348E2B389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A29E2F051442AF778941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6D082881546D9349175ECD9A6C639B01B78DA827A17800CE7994FE22CF3C16DE0731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A53CE1FFDCC8BC3F875002B1117B3ED6967C691E923BCFEC3E4A0A47EBA01A636A823CB91A9FED034534781492E4B8EEAD37F46C620FF2CAEEBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6594C9A9991091F54A83E8331F0C0B5A478626DAB97AFA6EC659FD521F486BBF8CC8D09C4D9C38F483AB8341EE9D5BE9A0A20257CA172D512CEDB56A7387F9E36094629CDC5874DC30D8CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdtTL5f5BIXbd8e9dDt96rA= X-DA7885C5: 72D9D000825884B1F255D290C0D534F911D2C4A6AEEB10603DB6EBF49B30FF0906C1FC9D1C7169F65B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD2C516F8BD413AC71C202837CB2EB6575F67358AC5FF4017F3E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 01/41] perf: add LuaJIT-test-cleanup perf suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answers below. On 11.11.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! > > This is a big step forward for LuaJIT performance testing. > > Please take a look on the comments below. > > Sergey > > On 10/24/25 13:50, Sergey Kaplun wrote: > > This patch introduces the LuaJIT-test-cleanup bench suite [1] into our > s/bench/benchmark/ Fixed. > > LuaJIT fork source tree. To provide relatable reprodusible results > > did not get it: "relatable" I've meant reliable. Fixed. > > s/reprodusible/reproducible/ Fixed, thanks! > > > several benchmarks need to be adjusted. However, to be sure we initially use > > the valid suite, everything in the directory is > > moved intact. > > > > [1]:https://github.com/LuaJIT/LuaJIT-test-cleanup/tree/014708b/bench The new commit message is the following: | perf: add LuaJIT-test-cleanup perf suite | | This patch introduces the LuaJIT-test-cleanup benchmark suite [1] into | our LuaJIT fork source tree. To provide reliable reproducible results | several benchmarks need to be adjusted. However, to be sure we initially | use the valid suite, everything in the directory | is moved intact. | | [1]: https://github.com/LuaJIT/LuaJIT-test-cleanup/tree/014708b/bench > > + 'perf/LuaJIT-benches/', > > Please don't do this. It is better to ignore by code number and at least > > some groups of warnings in the code. > It is not clear anyway what these magic numbers mean. For now it is just more convenient to disable the full set of the added suite, since we need to ignore the enormous amount of warnings. We may refactor it later if we have such a need. I'm not sure that this particular suite will be updated somehow in the future, so this format looks acceptable. We have the same approach for LuaJIT tests and PUC-Rio-Lua-5.1 tests > > It is not clear why exactly these parameters are used. I suppose this is the empirical setup that Mike thinks is optimal. > > Should we change them? > This commit brings the original code as is. So, no, we don't need to change them here. > > Do we really need parameters for unsupported platforms (MIPS, x86, ppc)? > > it deserves a comment in commit message > This commit brings the original code as is. So, no, we don't need to change it here. > please remove a newline > ... > trailing newline > ... > unnecessary newline > ... > unnecessary newline > ... > unnecessary newline > ... > trailing space This commit brings the original code as is. So, no, we don't need to change it here. It should be removed in the corresponding refactoring commit if you insist. -- Best regards, Sergey Kaplun