From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BC2D115C7C01; Thu, 27 Nov 2025 12:50:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BC2D115C7C01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1764237047; bh=BAglZ+/yCPRkAAsntHTTISGrMIji9N9E/6LwWOgfUPU=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=JYX3pqK7nmTr4II2i5l+35Lz0Z231BGVGr16T//qnazUQOwab0SsxYZ+QjaF29Z6L 9ickEFm6StnhJP2YGlmMUPYUcvi4ISkqYwlfxXYJg0ByS0YKBMeADX97416T2FaA6o BTKSzGHBK1QVg17ds72GknXwc5Ts7Oui4gqnpe1A= Received: from send220.i.mail.ru (send220.i.mail.ru [95.163.59.59]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 91EE215C7C01 for ; Thu, 27 Nov 2025 12:50:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 91EE215C7C01 Received: by exim-smtp-6c58c594f5-cgkbx with esmtpa (envelope-from ) id 1vOYeD-00000000Urc-0ZUc; Thu, 27 Nov 2025 12:50:45 +0300 Date: Thu, 27 Nov 2025 12:50:44 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <5cc97979-5691-4945-aa7b-44b0eb191c73@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5cc97979-5691-4945-aa7b-44b0eb191c73@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD990A6E13C587E340DDFD52A2D636814B672AA00B2E625291C00894C459B0CD1B959EA69FD7B13F8CFC8659717DE992388312AE6058CCEFB8F131066D50D26B6D01E0A116AA96AFE1E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7444CB0504BAF4550EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375660CC9DC0D4886FBE8C0DCDFC87275E8E8175DF3E2B4F6E03668AC2C448C1B2A61389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C091DAD9F922AA71188941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6E5E764EB5D94DBD4CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7B2B7C64F398C7410731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5127292B1973E79295002B1117B3ED696BAFAA3693944EE26C89B063BDC7FAC35823CB91A9FED034534781492E4B8EEAD5E90D3DD2A5B7EAFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659BD1702A71A33870D2C6AC834513EAFE002A3B320A09FF05CE0994221234F94C2F24C4E1DEC8F19F6B8341EE9D5BE9A0AEF299A0A645E17A66965337D253F793F8F03952D79EB385B8CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVcWupAQoUeGvHjuIYA3iufY= X-DA7885C5: 5AD5D99A1E1E2874F255D290C0D534F95D0A2C788973D48C70D603692CD0AABBA012D030EF5540B95B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD23D5F98B108ED5D454067F1C22A7FBCEB582A92917FE986C5E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] macOS: Fix macOS 15 / Clang 16 build. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment and updated the branch. On 25.11.25, Sergey Bronnikov wrote: > Hi, Sergey! > > Thanks for the patch! LGTM with a minor comment. > > Sergey > > On 11/24/25 23:26, Sergey Kaplun wrote: > > From: Mike Pall > > > > Note: The -Wl,-no_deduplicate workaround is NOT needed anymore. > > Thanks to fxcoudert, corsix, clason, baconpaul, mvf. > > > > (cherry picked from commit 2240d84464cc3dcb22fd976f1db162b36b5b52d5) > > > > When building LuaJIT in the non-Debug mode, the -O2 optimization flag is > > applied for both the compiler and the linker. Thus, the linker may apply > > various optimizations, such as code deduplication. Since macOS 15, the > > bundled Clang provided by Xcode tools may wrongly deduplicate the part > > of the LuaJIT VM. One workaround may be to provide a flag to the linker > > `-Wl,-no_deduplicate` [1], which helps to avoid wrong deduplication. The > > other option is to remove emitting `.subsections_via_symbols` [2] to > > avoid shrinking the object file by the labels. > > > > The second option is more robust, since there is no rationale why this > > directive was added in the past. > > > > [1]:https://rocm.docs.amd.com/projects/llvm-project/en/latest/LLVM/lld/html/MachO/ld64-vs-lld.html > > [2]:https://reviews.llvm.org/D79926 > > I would also add a link to Mach-O File Format Reference [1]. We already > referred to it in the commit 6e3aad8fb65f20a294171620b2e3bb4a8287e9b3 > ("OSX/iOS/ARM64: Fix generation of Mach-O object files."). > Feel free to ignore. > > 1. https://github.com/aidansteele/osx-abi-macho-file-format-reference Indeed, this link is brilliant, added. The new commit message is the following: | macOS: Fix macOS 15 / Clang 16 build. | | Note: The -Wl,-no_deduplicate workaround is NOT needed anymore. | Thanks to fxcoudert, corsix, clason, baconpaul, mvf. | | (cherry picked from commit 2240d84464cc3dcb22fd976f1db162b36b5b52d5) | | When building LuaJIT in the non-Debug mode, the -O2 optimization flag is | applied for both the compiler and the linker. Thus, the linker may apply | various optimizations, such as code deduplication. Since macOS 15, the | bundled Clang provided by Xcode tools may wrongly deduplicate the part | of the LuaJIT VM. One workaround may be to provide a flag to the linker | `-Wl,-no_deduplicate` [1], which helps to avoid wrong deduplication. The | other option is to remove emitting `.subsections_via_symbols` [2][3] to | avoid shrinking the object file by the labels. | | The second option is more robust, since there is no rationale why this | directive was added in the past. | | [1]: https://rocm.docs.amd.com/projects/llvm-project/en/latest/LLVM/lld/html/MachO/ld64-vs-lld.html | [2]: https://reviews.llvm.org/D79926 | [3]: https://github.com/aidansteele/osx-abi-macho-file-format-reference | | Sergey Kaplun: | * added the description for the problem | | Part of tarantool/tarantool#11691 > > -- Best regards, Sergey Kaplun