From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DDB1215C5E38; Thu, 27 Nov 2025 12:44:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DDB1215C5E38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1764236678; bh=5c53KqxJApaj5Rh/Lyu9HD7HrJQ8kPrMgrsqt2MWBEU=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=trrOL50t5MdSZxjuZ78yVrt3+SU6cxLB3/an6njyBU9BcvaFhk992A18zQr9GpTIx sgvSUPEYGtxpcwJR1sSLlT+HW6IWnCWjUcX4FoGCSiCKsaa98eiUssvMLmVHbONuBO 01N69ih39onTyWxegI5H8q6HWjf2hshLEKo//5y4= Received: from send128.i.mail.ru (send128.i.mail.ru [89.221.237.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3EAC951FE3A for ; Thu, 27 Nov 2025 12:44:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3EAC951FE3A Received: by exim-smtp-6c58c594f5-swvnp with esmtpa (envelope-from ) id 1vOYYF-00000000VqD-0HDf; Thu, 27 Nov 2025 12:44:35 +0300 Date: Thu, 27 Nov 2025 12:44:34 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <08ffbaee95a92ee9c166fa70b78e2d98c06928a2.1763991490.git.skaplun@tarantool.org> <0b86c212-f997-4fc2-afa0-37cf948cb5ed@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0b86c212-f997-4fc2-afa0-37cf948cb5ed@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD990A6E13C587E340DB9213BDD0CD9CBE4CE0169022F2B940900894C459B0CD1B916FA23E552B6BA33B4227B83FC9362CBD0C15963A1B7B21447B39A0688A5A425E1C7414A75FA687D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E50EC9128971FD6EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FE9EFE935CD7C6AE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B216A180A20AAB51CF2E070BE324C7D3C4EA33D41D88DD41EFF6B57BC7E64490618DEB871D839B73339E8FC8737B5C224952D31B9D28593E51CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0DEC8C2C8BCD2534D8941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C369456C5265B6C55C35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A51F92338BB7F460A35002B1117B3ED6967AB2C9556554145A3D2BBC1EF78EDEBE823CB91A9FED034534781492E4B8EEAD4ECBDE8281F904F9BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6595643AF64BE546159234CEA3EFCA40275560B208F176F2BDA576930716D96B9196FDFEBA24C4C39C1B8341EE9D5BE9A0AF982E130A4E0D81C55A0549716D80895FEB6D6745A12DA858CD93680B12512CF4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVcWupAQoUeGvtTOv1xDgu08= X-DA7885C5: DDF32613CC82CB14F255D290C0D534F991795DFCECBB790438D87F500EF72E6D05FE8AE490344F215B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD29D5004F7FD3D1A7F6A7E3389D63EB6576730F46AA5CEEED7E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] macOS: Remove obsolete -single_module flag. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! See my clarification below. On 26.11.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with two minor comments. > > Sergey > > On 11/24/25 23:26, Sergey Kaplun wrote: > > From: Mike Pall > > > > Thanks to dundargoc. > > > > (cherry picked from commit 97813fb924edf822455f91a5fbbdfdb349e5984f) > > > > The aforementioned flag is the default since Xcode 2.2 [1]. > > You refer to the description in the previous commit, right? > > I would name a flag here instead It is mentioned in the commit message header, so I refer to the commit message header, not the previous commit. Hence, I don't see the reason to mention it again. > > > This patch removes this flag to avoid warnings for modern Xcode > > versions at the linking stage. > it is worth to mention our own modifications for CMake build system I suppose this is excess since this is the details of the implemenatation. > > -- Best regards, Sergey Kaplun