From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AD7E415138DD; Tue, 9 Sep 2025 12:43:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AD7E415138DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1757410998; bh=AzzXctWj8emaNzeSjwPRPlrb4O5ohTAU0bMxieH3kbk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=uCF4tuW8OX/pwv8o82klup+lo13sMjieqs4TEd6DHktAjTLeu8jxqB0HiuespxKpH /DmsXlgrTyqVnm1BuT4r1KtahupS/TV+SRNq2wsooBupENMRhl3XWhYeUuu0DqfPUE mcswFiPl9qB8gIkMYTA5p0eyk0Eq6PtcedKwlH8s= Received: from send57.i.mail.ru (send57.i.mail.ru [89.221.237.152]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7981615138E2 for ; Tue, 9 Sep 2025 12:43:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7981615138E2 Received: by exim-smtp-c584fb9f-lmjng with esmtpa (envelope-from ) id 1uvuse-000000004uM-2Obj; Tue, 09 Sep 2025 12:43:17 +0300 Date: Tue, 9 Sep 2025 12:44:05 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <20250819074020.12306-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9F0F7827A03D16B76219C719DF7774CCA36544EAFBBB2E416182A05F538085040168C9CE426CD59733DE06ABAFEAF670582B5F158ACE27D33E5C650CA057E70963B45A48541D55DDE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE742D9BD90C58D50E0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F88016AB904663428638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B269E41E381AAFBB102E070BE324C7D3C42E61C1A5800CCAA0F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249A70DDFFB3186CBC5CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C084ED00A64A654CBE8941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3C74813BC7F81EC8435872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5766AC881E962A8755002B1117B3ED696E990CF9074738A09108A05421C070DB8823CB91A9FED034534781492E4B8EEAD9DB614F8F96CFA30BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF18972BB3504A62D298A790F5176C81EC0CF34ABAFC07E6DCC1B017FB7E55095CF31E0254ADC75A061E832756A85E66F7F13F16B87A09ADA0D3BD2DE0B25741C1C930509D88FD6EA5111DC66A97D0BFE2913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdVMtzNxwZu5kEXxnHbxLjM= X-DA7885C5: A92C70676E6B1BE0F255D290C0D534F9BAE172AF83E769DF44528E8C992C01408E92CD6908E4B0DB5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393FE9E42A757851DB674A12A7D2582643E7D4CB00E4DD59D03261B9C342DA37E84E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Correctly close VM state after early OOM during open. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment and force-pushed the branch. On 09.09.25, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with a minor comment. > > Sergey > > On 8/19/25 10:40, Sergey Kaplun wrote: > > + /* > > + * Check that there is no crash and the limit is small enough. > > + */ > > + lua_State *L = lua_newstate(limited_alloc_f, NULL); > s/lua_State/const lua_State/ Fixed, thanks! =================================================================== diff --git a/test/tarantool-c-tests/lj-1248-close-state-early-OOM.test.c b/test/tarantool-c-tests/lj-1248-close-state-early-OOM.test.c index 6c9cb2ca..fe91d5e9 100644 --- a/test/tarantool-c-tests/lj-1248-close-state-early-OOM.test.c +++ b/test/tarantool-c-tests/lj-1248-close-state-early-OOM.test.c @@ -49,7 +49,7 @@ static int limited_memory_on_lua_newstate(void *test_state) /* * Check that there is no crash and the limit is small enough. */ - lua_State *L = lua_newstate(limited_alloc_f, NULL); + const lua_State *L = lua_newstate(limited_alloc_f, NULL); assert_true(L == NULL); return TEST_EXIT_SUCCESS; #endif =================================================================== > > + assert_true(L == NULL); > > + return TEST_EXIT_SUCCESS; > > +#endif > > +} > > + > > +#ifndef LJ_NO_UNWIND > > +# define LJ_NO_UNWIND 0 > > +#endif > > + > > +int main(void) > > +{ > > + /* Seehttps://github.com/LuaJIT/LuaJIT/issues/1311. */ > > + if (!LJ_NO_UNWIND) > > + return skip_all("Disabled for external unwinding build due to #1311"); > > + const struct test_unit tgroup[] = { > > + test_unit_def(limited_memory_on_lua_newstate), > > + }; > > + return test_run_group(tgroup, NULL); > > +} -- Best regards, Sergey Kaplun