From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BC9B113EBF42; Fri, 6 Jun 2025 18:14:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BC9B113EBF42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1749222889; bh=k9a/NKa97UtLVElbM2nYPXMpGTZRBGM7eOxzSRCmbB0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=jp8hubeGS/+BRrYysXAvqU5C/HF5yDCeWYXXejYGa/CBwDr6shzr4IeCsUgvQ0Blv nKoYwFjmr1UD0f49DCAcHTlllDVku7d2pC/3TNWALPuwUwnK8vdJmdKRTPcm7o4d+J wfLBpkcHmqp5PfxKSakmjTkDn2lH5pum72hvaSpI= Received: from send218.i.mail.ru (send218.i.mail.ru [95.163.59.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1396613EBF40 for ; Fri, 6 Jun 2025 18:14:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1396613EBF40 Received: by exim-smtp-567cc788d4-nhqkn with esmtpa (envelope-from ) id 1uNYmO-00000000Ds0-1Gxt; Fri, 06 Jun 2025 18:14:48 +0300 Date: Fri, 6 Jun 2025 18:14:52 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: <5720c23a8dd4dbd5e2879b1ea163b7d140b0faf9.1749101434.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95E97EA1894635BC3577730E5842974C3FC041FD805BFA975182A05F538085040127A229B6A2E70FD3DE06ABAFEAF67058AE33D8B244D43AE4064AC0961C08E2768F8FE4CC13662E2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AEA4A6B3AFC9B957C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7353CFE866E745C13EA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA65869B7A1C18548B85346F20FEE803C3BA9C426C3A2269AFCC4117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6AC294AFEFA671E80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A551FA3A1774B5031A5002B1117B3ED69605DBD018AA6C2B6B19AC5B239BAD4335823CB91A9FED034534781492E4B8EEADB1D70E2111C441FFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3454E98140CCACB5B330485E44356DE59FF7A7050F6CB2D438BE932CA0F813F961AF2936214F60DB851D7E09C32AA3244C727F888317C4320277DD89D51EBB7742F5CDEFBDDA7C0AC8EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVSykAyseJQ6/TCc2BFVMnks= X-DA7885C5: FBEF240192E696C1F255D290C0D534F93CA2A61DA2AED0F634AC4DFDEDA91E231E72982B6AC8C14F5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393FE9E42A757851DB6442DB5FD263AE6FB957DC333F2B7FAB72920FF1D1B1F0341E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] Fix potential file descriptor leak in luaL_loadfile*(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 06.06.25, Sergey Bronnikov wrote: > Hello, Sergey, > > the test is passed when CMake option -DLUAJIT_USE_VALGRIND=ON is used and > > patch with fix is reverted. You should run it with the corresponding env variable (like it is done in the CI), see the comment in the test header: | VALGRIND_OPTS="--track-fds=yes" ctest -V -R lj-1249 > > Sergey -- Best regards, Sergey Kaplun