From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D7C0913E9569; Fri, 6 Jun 2025 17:03:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D7C0913E9569 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1749218629; bh=XZnR6ldkZ3Ldh8JvNDLvZLIpyb0S7Qq+WcfAjVQ2cPw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ilbpcKBj5hR6IhBLplicVpqznVOfIxyNMP+9deyc1SrCsVPRw7Baff9lbABnBtuu5 K9XzwqZZ9XJZkCiCkRIZOJ2o9uFT5KYqzzJbrcAjVYCss451P98E23LRl9mafzVgaO XIFg31tNaUAakjXxWqDyNFycjFXDHJMEppygfa0Q= Received: from send149.i.mail.ru (send149.i.mail.ru [89.221.237.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B5D0213E9569 for ; Fri, 6 Jun 2025 17:03:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B5D0213E9569 Received: by exim-smtp-567cc788d4-2v457 with esmtpa (envelope-from ) id 1uNXff-00000000DWP-2tHV; Fri, 06 Jun 2025 17:03:47 +0300 Date: Fri, 6 Jun 2025 17:03:47 +0300 To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95E97EA1894635BC3460DB2E43CD50E3E5907F655368299E5182A05F5380850407F77E320CA82E1E63DE06ABAFEAF67052898D356643C1AAF1C59987DA4337F2F4868178014C6CACD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B264C8851FD8E810EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756680FD86C7FE90CFE5F0FFECBDF89B4EAA18C536D64EC5576AF51EA54563BA172F389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7D151390FFDBF6399731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A52BC57264AD03FB5A5002B1117B3ED69622306B625B9150775B6221DB6D7A72AD823CB91A9FED034534781492E4B8EEAD831CA35E4C50C31B X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C1E32F4AD4B2486B9E507463A8768205CE8C82192FFEF5DAE6F600D1D4634E1423C6A4352466DCC21D7E09C32AA3244C603FA73D3585E2D777DD89D51EBB77421AAFBA0BB1C872E4EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVSykAyseJQ6/FZVYkbdH/K8= X-DA7885C5: 5E6DB49712972D0CF255D290C0D534F924AEA9193BCE5F182B3113D150A354805B944ABEF1291FA65B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393FE9E42A757851DB6A55CDB2EAA2864AC79425B81BB48C8B30A0E406B2754C592E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] ci: add track-fds Valgrind scenario X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answers below. On 06.06.25, Sergey Bronnikov wrote: > Hello, Sergey, > > Thanks for the patch! See my comments below. > > On 6/5/25 08:44, Sergey Kaplun wrote: > > This patch adds a new field, track-fds [1], in the Valgrind workflow > > matrix to detect descriptor leakage in the tests. > > > > [1]:https://valgrind.org/docs/manual/manual-core.html#opt.track-fds > > > > Needed for tarantool/tarantool#11278 > > --- > > .github/workflows/valgrind-testing.yaml | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/.github/workflows/valgrind-testing.yaml b/.github/workflows/valgrind-testing.yaml > > index e6606478..b3c7bc80 100644 > > --- a/.github/workflows/valgrind-testing.yaml > > +++ b/.github/workflows/valgrind-testing.yaml > > @@ -38,7 +38,11 @@ jobs: > > # Therefore, testing on this platform is currently > > # disabled. > > BUILDTYPE: [Debug, Release] > > - VALGRIND_SCENARIO: [full, malloc-free-fill-0x00, malloc-free-fill-0xff] > > + VALGRIND_SCENARIO: > > + - full > > + - malloc-free-fill-0x00 > > + - malloc-free-fill-0xff > > + - track-fds > Why we cannot add "track-fds" to the existed scenario? I've thought to add this flag to the "full" scenario. But then I realized that we already have "full" workflow running too long, and the parallel shorter task will not slow the CI, I suppose. > > include: > > - BUILDTYPE: Debug > > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > > @@ -59,6 +63,9 @@ jobs: > > - VALGRIND_SCENARIO: malloc-free-fill-0xff > > VALGRIND_OPTS: --leak-check=no --malloc-fill=0xff --free-fill=0xff > > JOB_POSTFIX: "malloc/free-fill: 0xff" > > + - VALGRIND_SCENARIO: track-fds > > According to documentation, the option "print out a list of open file > descriptors on exit or on request". > > So the fd leak detection is semi-automated. How it should work on CI? The fd not checked on exit without this flag. I suppose the wording in the Valgrind's documentation isn't perfect. You may test it locally with and without the corresponding flag in the`VALGRIND_OPTS` env variable. > > > + VALGRIND_OPTS: --leak-check=no --track-fds=yes > > + JOB_POSTFIX: "track-fds" > > runs-on: [self-hosted, regular, Linux, x86_64] > > name: > > > LuaJIT with Valgrind (Linux/x86_64) -- Best regards, Sergey Kaplun