From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 610A913EB620; Fri, 6 Jun 2025 17:54:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 610A913EB620 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1749221681; bh=GnjMFW8q4OMLWwXut/Febl9Pr2HSuGckiAjvLHLWxa8=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=zktR2e59LBda7zdZnpeX4QmZZXmZTuT7YOm+e7E/uRy0RgUrpq1/MEEA0h86FzRFS u/cqph7PXr/lnfrb1Xw6wc+rs/YHD/4HXsfYhczympqlitbew7iMsNsNeKLRdVUoB8 8FJzPO6zEozQ7Wm9c166dFAtLkMqnN0fGQkb2K1s= Received: from send218.i.mail.ru (send218.i.mail.ru [95.163.59.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C7E8513EB623 for ; Fri, 6 Jun 2025 17:54:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C7E8513EB623 Received: by exim-smtp-567cc788d4-xsdzx with esmtpa (envelope-from ) id 1uNYSt-00000000QAA-374d; Fri, 06 Jun 2025 17:54:40 +0300 Content-Type: multipart/alternative; boundary="------------951wKrrvW4eN0XFRQrJMXoZ5" Message-ID: Date: Fri, 6 Jun 2025 17:54:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95E97EA1894635BC30BDA652621C30F1215A06768B9B6C4E5182A05F538085040FBBF9F07D18E8F873DE06ABAFEAF670584ACE77C7CAD27C2144D4D864074489CA2698D7B1DC6BD28 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB7B102DCB413779EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756680FD86C7FE90CFE5C81A2ED7560E8D4A989D38A811437D6C18964EF5B9654B98389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22490F250D17497FEF6176E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B8DBB596EC94336063AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D2457FAF19517CF2C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A54D8E6FA44C5038825002B1117B3ED696A9C7FFE9FA14B0260E58516B1639A14B823CB91A9FED034534781492E4B8EEAD47A3109F1ACFD409BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFB87DD1823334DC6CDDA167DFC9989867A0BC6904286D09C2F498B749D8AB06734905B00F5DFE93A24322DC41441C31F04E876C80CA9EBDD1722A4BA29E6D54D4F1458BF176D59C5F111DC66A97D0BFE2913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVSykAyseJQ6/tYJGfHvirhw= X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140C22F9ECD7ABFFD264BD03525DDD6C896FDF79ACDC71ECA500152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] ci: add track-fds Valgrind scenario X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------951wKrrvW4eN0XFRQrJMXoZ5 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Sergey, On 6/6/25 17:03, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Please consider my answers below. > > On 06.06.25, Sergey Bronnikov wrote: >> Hello, Sergey, >> >> Thanks for the patch! See my comments below. >> >> On 6/5/25 08:44, Sergey Kaplun wrote: >>> This patch adds a new field, track-fds [1], in the Valgrind workflow >>> matrix to detect descriptor leakage in the tests. >>> >>> [1]:https://valgrind.org/docs/manual/manual-core.html#opt.track-fds >>> >>> Needed for tarantool/tarantool#11278 >>> --- >>> .github/workflows/valgrind-testing.yaml | 9 ++++++++- >>> 1 file changed, 8 insertions(+), 1 deletion(-) >>> >>> diff --git a/.github/workflows/valgrind-testing.yaml b/.github/workflows/valgrind-testing.yaml >>> index e6606478..b3c7bc80 100644 >>> --- a/.github/workflows/valgrind-testing.yaml >>> +++ b/.github/workflows/valgrind-testing.yaml >>> @@ -38,7 +38,11 @@ jobs: >>> # Therefore, testing on this platform is currently >>> # disabled. >>> BUILDTYPE: [Debug, Release] >>> - VALGRIND_SCENARIO: [full, malloc-free-fill-0x00, malloc-free-fill-0xff] >>> + VALGRIND_SCENARIO: >>> + - full >>> + - malloc-free-fill-0x00 >>> + - malloc-free-fill-0xff >>> + - track-fds >> Why we cannot add "track-fds" to the existed scenario? > I've thought to add this flag to the "full" scenario. But then I > realized that we already have "full" workflow running too long, and the > parallel shorter task will not slow the CI, I suppose. Ok. >>> include: >>> - BUILDTYPE: Debug >>> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON >>> @@ -59,6 +63,9 @@ jobs: >>> - VALGRIND_SCENARIO: malloc-free-fill-0xff >>> VALGRIND_OPTS: --leak-check=no --malloc-fill=0xff --free-fill=0xff >>> JOB_POSTFIX: "malloc/free-fill: 0xff" >>> + - VALGRIND_SCENARIO: track-fds >> According to documentation, the option "print out a list of open file >> descriptors on exit or on request". >> >> So the fd leak detection is semi-automated. How it should work on CI? > The fd not checked on exit without this flag. I suppose the wording in > the Valgrind's documentation isn't perfect. > > You may test it locally with and without the corresponding flag in > the`VALGRIND_OPTS` env variable. FD leak is detected but test is passed: UpdateCTestConfiguration  from :/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/DartConfiguration.tcl UpdateCTestConfiguration  from :/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/DartConfiguration.tcl Test project /home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64 Constructing a list of tests Done constructing a list of tests Updating test list for fixtures Added 0 tests to meet fixture requirements Checking test dependency graph... Checking test dependency graph end test 154     Start 154: test/tarantool-tests/lj-1249-loadfile-fd-leak.test.lua 154: Test command: /bin/valgrind "--leak-check=no" "--track-fds=yes" "--error-exitcode=1" "--suppressions=/home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/lj.supp" "--suppressions=/home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/lj_extra.supp" "/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/src/luajit" "-e" "dofile[[/home/sergeyb/sources/MRG/tarantool/third_party/luajit/test/luajit-test-init.lua]]" "/home/sergeyb/sources/MRG/tarantool/third_party/luajit/test/tarantool-tests/lj-1249-loadfile-fd-leak.test.lua" 154: Working Directory: /home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/test/tarantool-tests 154: Environment variables: 154: LUA_PATH=/home/sergeyb/sources/MRG/tarantool/third_party/luajit/test/tarantool-tests/?.lua;/home/sergeyb/sources/MRG/tarantool/third_party/luajit/test/tarantool-tests/?/init.lua;/home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/?.lua;/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/src/?.lua;; 154:  LUAJIT_TEST_USE_VALGRIND=1 154: LUA_CPATH=/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/test/tarantool-tests/utils/?.so; 154: LD_LIBRARY_PATH=/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/test/tarantool-tests/utils: 154: Test timeout computed to be: 10000000 154: ==2176604== Memcheck, a memory error detector 154: ==2176604== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al. 154: ==2176604== Using Valgrind-3.22.0 and LibVEX; rerun with -h for copyright info 154: ==2176604== Command: /home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/src/luajit -e dofile[[/home/sergeyb/sources/MRG/tarantool/third_party/luajit/test/luajit-test-init.lua]] /home/sergeyb/sources/MRG/tarantool/third_party/luajit/test/tarantool-tests/lj-1249-loadfile-fd-leak.test.lua 154: ==2176604== 154: TAP version 13 154: 1..4 154: ok - correct status, OOM on filename creation 154: ok - correct error message, OOM on filename creation 154: ok - correct status, OOM on error message creation 154: ok - correct error message, OOM on error message creation 154: ==2176604== 154: ==2176604== FILE DESCRIPTORS: 5 open (3 std) at exit. 154: ==2176604== Open file descriptor 4: /dev 154: ==2176604==    at 0x4ABB175: open (open64.c:41) 154: ==2176604==    by 0x4A31B0E: _IO_file_open (fileops.c:188) 154: ==2176604==    by 0x4A31E51: _IO_file_fopen@@GLIBC_2.2.5 (fileops.c:281) 154: ==2176604==    by 0x4A25EE1: __fopen_internal (iofopen.c:75) 154: ==2176604==    by 0x4A25EE1: fopen@@GLIBC_2.2.5 (iofopen.c:86) 154: ==2176604==    by 0x1FAB1E: luaL_loadfilex (src/lj_load.c:92) 154: ==2176604==    by 0x217F18: lj_cf_loadfile (src/lib_base.c:384) 154: ==2176604==    by 0x2A19B9: lj_BC_FUNCC (/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/src/lj_vm.S:899) 154: ==2176604==    by 0x1E7C81: lua_pcall (src/lj_api.c:1173) 154: ==2176604==    by 0x1D738F: docall (src/luajit.c:134) 154: ==2176604==    by 0x1D6E56: handle_script (src/luajit.c:304) 154: ==2176604==    by 0x1D615B: pmain (src/luajit.c:602) 154: ==2176604==    by 0x2A19B9: lj_BC_FUNCC (/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/src/lj_vm.S:899) 154: ==2176604== 154: ==2176604== Open file descriptor 3: /home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/Testing/Temporary/LastTest.log.tmp 154: ==2176604==    154: ==2176604== 154: ==2176604== 154: ==2176604== HEAP SUMMARY: 154: ==2176604==     in use at exit: 472 bytes in 1 blocks 154: ==2176604==   total heap usage: 1,253 allocs, 1,252 frees, 179,771 bytes allocated 154: ==2176604== 154: ==2176604== For a detailed leak analysis, rerun with: --leak-check=full 154: ==2176604== 154: ==2176604== For lists of detected and suppressed errors, rerun with: -s 154: ==2176604== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 67 from 18) 1/1 Test #154: test/tarantool-tests/lj-1249-loadfile-fd-leak.test.lua ... Passed    0.77 sec The following tests passed:     test/tarantool-tests/lj-1249-loadfile-fd-leak.test.lua 100% tests passed, 0 tests failed out of 1 Label Time Summary: tarantool-tests    =   0.77 sec*proc (1 test) Total Test time (real) =   0.79 sec >>> + VALGRIND_OPTS: --leak-check=no --track-fds=yes >>> + JOB_POSTFIX: "track-fds" >>> runs-on: [self-hosted, regular, Linux, x86_64] >>> name: > >>> LuaJIT with Valgrind (Linux/x86_64) --------------951wKrrvW4eN0XFRQrJMXoZ5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Sergey,


On 6/6/25 17:03, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Please consider my answers below.

On 06.06.25, Sergey Bronnikov wrote:
Hello, Sergey,

Thanks for the patch! See my comments below.

On 6/5/25 08:44, Sergey Kaplun wrote:
This patch adds a new field, track-fds [1], in the Valgrind workflow
matrix to detect descriptor leakage in the tests.

[1]:https://valgrind.org/docs/manual/manual-core.html#opt.track-fds

Needed for tarantool/tarantool#11278
---
  .github/workflows/valgrind-testing.yaml | 9 ++++++++-
  1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/valgrind-testing.yaml b/.github/workflows/valgrind-testing.yaml
index e6606478..b3c7bc80 100644
--- a/.github/workflows/valgrind-testing.yaml
+++ b/.github/workflows/valgrind-testing.yaml
@@ -38,7 +38,11 @@ jobs:
          # Therefore, testing on this platform is currently
          # disabled.
          BUILDTYPE: [Debug, Release]
-        VALGRIND_SCENARIO: [full, malloc-free-fill-0x00, malloc-free-fill-0xff]
+        VALGRIND_SCENARIO:
+          - full
+          - malloc-free-fill-0x00
+          - malloc-free-fill-0xff
+          - track-fds
Why we cannot add "track-fds" to the existed scenario?
I've thought to add this flag to the "full" scenario. But then I
realized that we already have "full" workflow running too long, and the
parallel shorter task will not slow the CI, I suppose.
Ok.

      
          include:
            - BUILDTYPE: Debug
              CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
@@ -59,6 +63,9 @@ jobs:
            - VALGRIND_SCENARIO: malloc-free-fill-0xff
              VALGRIND_OPTS: --leak-check=no --malloc-fill=0xff --free-fill=0xff
              JOB_POSTFIX: "malloc/free-fill: 0xff"
+          - VALGRIND_SCENARIO: track-fds
According to documentation, the option "print out a list of open file 
descriptors on exit or on request".

So the fd leak detection is semi-automated. How it should work on CI?
The fd not checked on exit without this flag. I suppose the wording in
the Valgrind's documentation isn't perfect.

You may test it locally with and without the corresponding flag in
the`VALGRIND_OPTS` env variable.

FD leak is detected but test is passed:


UpdateCTestConfiguration  from :/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/DartConfiguration.tcl
UpdateCTestConfiguration  from :/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/DartConfiguration.tcl
Test project /home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 154
    Start 154: test/tarantool-tests/lj-1249-loadfile-fd-leak.test.lua

154: Test command: /bin/valgrind "--leak-check=no" "--track-fds=yes" "--error-exitcode=1" "--suppressions=/home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/lj.supp" "--suppressions=/home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/lj_extra.supp" "/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/src/luajit" "-e" "dofile[[/home/sergeyb/sources/MRG/tarantool/third_party/luajit/test/luajit-test-init.lua]]" "/home/sergeyb/sources/MRG/tarantool/third_party/luajit/test/tarantool-tests/lj-1249-loadfile-fd-leak.test.lua"
154: Working Directory: /home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/test/tarantool-tests
154: Environment variables:
154:  LUA_PATH=/home/sergeyb/sources/MRG/tarantool/third_party/luajit/test/tarantool-tests/?.lua;/home/sergeyb/sources/MRG/tarantool/third_party/luajit/test/tarantool-tests/?/init.lua;/home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/?.lua;/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/src/?.lua;;
154:  LUAJIT_TEST_USE_VALGRIND=1
154:  LUA_CPATH=/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/test/tarantool-tests/utils/?.so;
154:  LD_LIBRARY_PATH=/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/test/tarantool-tests/utils:
154: Test timeout computed to be: 10000000
154: ==2176604== Memcheck, a memory error detector
154: ==2176604== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al.
154: ==2176604== Using Valgrind-3.22.0 and LibVEX; rerun with -h for copyright info
154: ==2176604== Command: /home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/src/luajit -e dofile[[/home/sergeyb/sources/MRG/tarantool/third_party/luajit/test/luajit-test-init.lua]] /home/sergeyb/sources/MRG/tarantool/third_party/luajit/test/tarantool-tests/lj-1249-loadfile-fd-leak.test.lua
154: ==2176604==
154: TAP version 13
154: 1..4
154: ok - correct status, OOM on filename creation
154: ok - correct error message, OOM on filename creation
154: ok - correct status, OOM on error message creation
154: ok - correct error message, OOM on error message creation
154: ==2176604==
154: ==2176604== FILE DESCRIPTORS: 5 open (3 std) at exit.
154: ==2176604== Open file descriptor 4: /dev
154: ==2176604==    at 0x4ABB175: open (open64.c:41)
154: ==2176604==    by 0x4A31B0E: _IO_file_open (fileops.c:188)
154: ==2176604==    by 0x4A31E51: _IO_file_fopen@@GLIBC_2.2.5 (fileops.c:281)
154: ==2176604==    by 0x4A25EE1: __fopen_internal (iofopen.c:75)
154: ==2176604==    by 0x4A25EE1: fopen@@GLIBC_2.2.5 (iofopen.c:86)
154: ==2176604==    by 0x1FAB1E: luaL_loadfilex (src/lj_load.c:92)
154: ==2176604==    by 0x217F18: lj_cf_loadfile (src/lib_base.c:384)
154: ==2176604==    by 0x2A19B9: lj_BC_FUNCC (/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/src/lj_vm.S:899)
154: ==2176604==    by 0x1E7C81: lua_pcall (src/lj_api.c:1173)
154: ==2176604==    by 0x1D738F: docall (src/luajit.c:134)
154: ==2176604==    by 0x1D6E56: handle_script (src/luajit.c:304)
154: ==2176604==    by 0x1D615B: pmain (src/luajit.c:602)
154: ==2176604==    by 0x2A19B9: lj_BC_FUNCC (/home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/src/lj_vm.S:899)
154: ==2176604==
154: ==2176604== Open file descriptor 3: /home/sergeyb/sources/MRG/tarantool/third_party/luajit/build/gc64/Testing/Temporary/LastTest.log.tmp
154: ==2176604==    <inherited from parent>
154: ==2176604==
154: ==2176604==
154: ==2176604== HEAP SUMMARY:
154: ==2176604==     in use at exit: 472 bytes in 1 blocks
154: ==2176604==   total heap usage: 1,253 allocs, 1,252 frees, 179,771 bytes allocated
154: ==2176604==
154: ==2176604== For a detailed leak analysis, rerun with: --leak-check=full
154: ==2176604==
154: ==2176604== For lists of detected and suppressed errors, rerun with: -s
154: ==2176604== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 67 from 18)
1/1 Test #154: test/tarantool-tests/lj-1249-loadfile-fd-leak.test.lua ...   Passed    0.77 sec

The following tests passed:
    test/tarantool-tests/lj-1249-loadfile-fd-leak.test.lua

100% tests passed, 0 tests failed out of 1

Label Time Summary:
tarantool-tests    =   0.77 sec*proc (1 test)

Total Test time (real) =   0.79 sec


      

        
+            VALGRIND_OPTS: --leak-check=no --track-fds=yes
+            JOB_POSTFIX: "track-fds"
      runs-on: [self-hosted, regular, Linux, x86_64]
      name: >
        LuaJIT with Valgrind (Linux/x86_64)

    
--------------951wKrrvW4eN0XFRQrJMXoZ5--