From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 716CE46970F
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 30 Nov 2019 04:04:13 +0300 (MSK)
References: <874875d2-9976-5e97-4898-9f2b6ddfe3fd@tarantool.org>
 <20191130000942.38265-1-k.sosnin@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <a92c2929-3911-f90d-1d14-8a866f015a9a@tarantool.org>
Date: Sat, 30 Nov 2019 02:04:10 +0100
MIME-Version: 1.0
In-Reply-To: <20191130000942.38265-1-k.sosnin@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2] tuple: fix non-informative
 update() error message
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>, tarantool-patches@dev.tarantool.org, Kirill Yukhin <kyukhin@tarantool.org>

Thanks for the fixes!

LGTM.

On 30/11/2019 01:09, Chris Sosnin wrote:
> Sorry for my mistake again, here is the diff:
> +		const char *str = tt_sprintf("wrong number of arguments, "\
> +					     "expected %u, got %u",
> +					     op->meta->arg_count, arg_count);
> 
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-3884-update-error
> issue: https://github.com/tarantool/tarantool/issues/3884
>