From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 284CF23CAA for ; Mon, 25 Feb 2019 06:59:43 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 83LYQ-AMe9If for ; Mon, 25 Feb 2019 06:59:43 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D095B227B5 for ; Mon, 25 Feb 2019 06:59:42 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v6 0/7] sql: set column types for EXPLAIN and PRAGMA References: From: Vladislav Shpilevoy Message-ID: Date: Mon, 25 Feb 2019 14:59:40 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, imeevma@tarantool.org Hi! Thanks for the fixes! On 21/02/2019 16:00, imeevma@tarantool.org wrote: > This patch-set defines the types for the result columns of EXPLAIN > and PRAGMA commands. In addition, it fixes some problems of the > PRAGMA commands that have something to do with their result. > > https://github.com/tarantool/tarantool/issues/3832 > https://github.com/tarantool/tarantool/tree/imeevma/gh-3832-no-column-types > > Changes in sixth version: > - Rebase to current 2.1 > - New patch that removes gh-3733-pragma.test.lua > - Other small fixes. Neither of these things are worth sending new patches in a new thread with a bumped version. Please, next time try to keep the discussion in the same thread if no drastic changes. The patchset is good now. Now, please, add docbot request to the last commit, describing changes in PRAGMA output. Including all the previous commits too. I mean, that 'PRAGMA' now returns name/value pairs, how now 'EXPLAIN' works, that 'sql_default_engine' and 'case_sensitive_like' return a current value, what does 'parser_trace', etc. Do not resend a new version. Just add a docbot request, signal here about it, and I will say LGTM.