From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 595F26EC55; Sun, 18 Jul 2021 20:00:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 595F26EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1626627632; bh=5hNe8qw6cqVIHvgmxyImoxxwIbNL45RUL4QW1FDHqPQ=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=vHpIE+611Hy0KbxgUSuPV16UgxtPjD3VZwd47XId8KTtk80dHyVb/9/+cLRn/vFik pL32UaqtkeSus4DIYkYtqKpA54FXlvz7eXKS1a0TxQ9lthLJTLLCNBAQpKcAdvoDjB gwKUwy2cbuzJ2odc6ODF2bkfuO5GheAXGRx1417k= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CED5D6EC55 for ; Sun, 18 Jul 2021 20:00:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CED5D6EC55 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1m5A9X-0002np-1I; Sun, 18 Jul 2021 20:00:31 +0300 To: Serge Petrenko , tarantool-patches@dev.tarantool.org, gorcunov@gmail.com References: <0c92a88ff1d392f8b03de59be8cb19a162bf78f8.1626392372.git.v.shpilevoy@tarantool.org> <37473da3-8525-16cb-f096-49c8c90e00d5@tarantool.org> Message-ID: Date: Sun, 18 Jul 2021 19:00:29 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <37473da3-8525-16cb-f096-49c8c90e00d5@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD941C43E597735A9C3A9514C5AE4B3B389A94BDFA06D40730D182A05F538085040E4C8F6B86AAD15E12E81B9D7F42FE8607DC6AB5547BBC96E16101F295756E6C3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7519D5B419DD3416AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CF19945FAF91394A8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80554D8AC8A0B7C947C7C00ADD7486288117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BAEB924C2B054B06E75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5DE8F7ED6A9F1F7EC315CAE0E3957BE1FBE97F3188E867E67D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C264B329661203DA3E2F80396A588AB3A805D08519C4EDA0804C0AF5ACB5AC73C7F41A16CCC226A81D7E09C32AA3244CF8C396E6AAF17D8442BB7189F71C1D3F81560E2432555DBBFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+8+KVR9NZrGvdFtGJqAQBw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D0714035549FC31619E8FACB66B719F513841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] replication: introduce ballot.can_be_leader X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review! > Hi and thanks for the patch! > > It's all good except the field name. It's rather long IMO, and may be > confused with bootsrap leader, which we try to find using ballots. > > Wouldn't "can be candidate", or "is_election_candidate" be better? `is_election_candidate` is even longer. I thought about `can_be_candidate` firstly, but then I realized that it is the same as `can_be_leader`, because the purpose of a candidate is to become a leader anyway. And we are looking for a leader, not a candidate. The latter is just an intermediate state. I shortened the name to `can_lead`. Ok? As for inability to boot a cluster we might in the future add a flag `can_boot` if necessary. See new patch in v2.