From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8F6E56ECE3; Wed, 15 Jun 2022 17:09:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8F6E56ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1655302175; bh=KMTKB0r6+MnyZJgnPhq4T6qSi+kc5kbHFEVE3Iz8jr0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=EOnPCVHc5xBq30a+UQSo3oyb3j9KdDFApE6MSGlaaS0i/M66TDWum3joqCJjCnyEC KYCCPdG7Reg8aiTwX2dNZ08G/ltFvS3n9z0mduPwS+4bfwEITUl+2m8w68HToKQqjH V2qG58Ip91iFcwi0mdg7M3WlWk2lAKwUlqNf/gWQ= Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 811A96ECE3 for ; Wed, 15 Jun 2022 17:09:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 811A96ECE3 Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1o1Ti9-00040F-I9; Wed, 15 Jun 2022 17:09:34 +0300 Message-ID: Date: Wed, 15 Jun 2022 17:09:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: Sergey Kaplun , Igor Munkin Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD97D44297578DBEB86125514212DDDA19BCD36CB7CF205A9D0182A05F5380850400A6D9024E4787F30A679A0C1CE7E6889C4AB2E43DDC106DA5F4012BFAF30110F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F87C043BA75DB4CEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637222645A8BD7B05AE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8779FA13DC761971E446763588B2A679E117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEF8AB6B2BE221812676E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B04F5A43DCAFB53113AA81AA40904B5D9DBF02ECDB25306B2201CA6A4E26CD07C3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735F3CCD8A865B74A75C4224003CC83647689D4C264860C145E X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1C8E4D5CD5A29D27931D26A3CEDA1AE9BC1F1979A4DC056701AD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3429499E429979B7C78FF18D16CF1EFEAB1DF5CA71071319E86036A95D005FA25480F7284EBF57803F1D7E09C32AA3244C35213816C720E33A9E48FE0896C59DBE5595C85A795C7BAEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojCCvLuneITNoRxv6RXXwKGg== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F25884581F57EB76C8B9CA32F1B611B2274E4E280B89C4B0C243B06E282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [v2][PATCH 5/5] ci: add job with build using Ninja on linux-x86_64 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey thanks for review! On 15.06.2022 12:27, Sergey Kaplun wrote: > Hi, Sergey! > > Thanks for the patch! > > LGTM, after fixes mentioned by Igor below and my 2 cents below. > > On 15.06.22, Igor Munkin via Tarantool-patches wrote: >> Sergey, >> >> Thanks for the patch! LGTM as trivial, but please consider nits below. >> >> On 06.06.22, Sergey Bronnikov wrote: >>> --- >>> .github/workflows/linux-x86_64-ninja.yml | 51 ++++++++++++++++++++++++ >>> 1 file changed, 51 insertions(+) >>> create mode 100644 .github/workflows/linux-x86_64-ninja.yml >>> >>> diff --git a/.github/workflows/linux-x86_64-ninja.yml b/.github/workflows/linux-x86_64-ninja.yml >>> new file mode 100644 >>> index 00000000..833d36d9 >>> --- /dev/null >>> +++ b/.github/workflows/linux-x86_64-ninja.yml >>> @@ -0,0 +1,51 @@ >>> +name: "LuaJIT test workflow with Ninja (Linux/x86_64)" >>> + >>> +on: >>> + push: >>> + branches-ignore: >>> + - '**-notest' >>> + - 'upstream-**' >>> + tags-ignore: >>> + - '**' >>> + >>> +concurrency: >>> + # An update of a developer branch cancels the previously >>> + # scheduled workflow run for this branch. However, the default >>> + # branch, and long-term branch (tarantool-1.10, tarantool-2.8, >>> + # etc.) workflow runs are never canceled. >>> + # >>> + # We use a trick here: define the concurrency group as 'workflow >>> + # run ID' + # 'workflow run attempt' because it is a unique >>> + # combination for any run. So it effectively discards grouping. >>> + # >>> + # XXX: we cannot use `github.sha` as a unique identifier because >>> + # pushing a tag may cancel a run that works on a branch push >>> + # event. >>> + group: ${{ ( >>> + github.ref == 'refs/heads/tarantool' || >>> + startsWith(github.ref, 'refs/heads/tarantool-')) && >>> + format('{0}-{1}', github.run_id, github.run_attempt) || >>> + format('{0}-{1}', github.workflow, github.ref) }} >>> + cancel-in-progress: true >>> + >>> +jobs: >>> + test-linux-x86_64: > Nit: May be `test-linux-ninja-x86_64` is better? > To be different from the same name for make target building? Agree, fixed: --- a/.github/workflows/linux-x86_64-ninja.yml +++ b/.github/workflows/linux-x86_64-ninja.yml @@ -29,10 +29,8 @@ concurrency:    cancel-in-progress: true  jobs: -  test-linux-x86_64: +  test-linux-ninja-x86_64:      runs-on: ubuntu-20.04-self-hosted > >>> + runs-on: ubuntu-20.04-self-hosted >>> + strategy: >>> + fail-fast: false > Nit: As far as there is no testing matrix we can omit strategy for it. Seems so [1]. Fixed with patch below: --- a/.github/workflows/linux-x86_64-ninja.yml +++ b/.github/workflows/linux-x86_64-ninja.yml @@ -31,8 +31,6 @@ concurrency:  jobs:    test-linux-x86_64:      runs-on: ubuntu-20.04-self-hosted -    strategy: -      fail-fast: false      name: Linux/x86_64 ${{ matrix.BUILDTYPE }}      steps:        - uses: actions/checkout@v2.3.4 1. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast > >>> + name: Linux/x86_64 ${{ matrix.BUILDTYPE }} >> There is no testing matrix, so you can just name the workflow kinda >> "Linux/x86_64 Ninja". Fixed too. >> >>> + steps: >>> + - uses: actions/checkout@v2.3.4 >>> + with: >>> + fetch-depth: 0 >>> + submodules: recursive >>> + - name: setup >>> + run: | >>> + sudo apt -y update >>> + sudo apt -y install cmake ninja-build gcc perl >>> + - name: configure >>> + run: cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -G Ninja >>> + - name: build >>> + run: cmake --build . -j $(nproc) >>> + - name: test >>> + run: cmake --build . -j $(nproc) -t test >> Please, use long options, as we discussed here[1]. Fixed: --- a/.github/workflows/linux-x86_64-ninja.yml +++ b/.github/workflows/linux-x86_64-ninja.yml @@ -44,6 +44,6 @@ jobs:        - name: configure          run: cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -G Ninja        - name: build -        run: cmake --build . -j $(nproc) +        run: cmake --build . --parallel $(($(nproc) + 1))        - name: test -        run: cmake --build . -j $(nproc) -t test +        run: cmake --build . --parallel $(($(nproc) + 1)) --target test >> >>> -- >>> 2.25.1 >>> >> [1]: https://lists.tarantool.org/tarantool-patches/YpjeijSClWO0v82Y@tarantool.org/ >> >> -- >> Best regards, >> IM