From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 471BA6ECDB; Fri, 2 Oct 2026 16:18:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 471BA6ECDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1790947120; bh=CqIef483CEHygAsVch2j9dMiGK8wMRVBG82HS4Po1ic=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=LCGbs5VCi4enMJ5thwdpFnWskVtWXBh8zhVH5Vxg8/YIBH2ZXmvQPnKBmVdzFvz4p r1T1NNWV6rw0Zv0M1og0zDZSZxjqmQtnqYs+C7Z0l3bzLLDLBakFgtHZOlLqZgLBmO 7FbsQ8BkKrunlNTISwfLbGhBK+DlCs6bdu6EsTX8= Received: from send172.i.mail.ru (send172.i.mail.ru [95.163.59.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 172AC6ECDB for ; Fri, 2 Oct 2026 16:18:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 172AC6ECDB Received: by exim-smtp-5bd9c49696-5dbb9 with esmtpa (envelope-from ) id 1xCd9p-00000000Be0-3xuQ; Fri, 02 Oct 2026 16:18:38 +0300 Message-ID: Date: Fri, 2 Oct 2026 16:18:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Alexander Turenko , Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <8b3a9c3bc1cae8b15954e8925fba9d751a4f051d.1790815412.git.alexander.turenko@tarantool.org> Content-Language: en-US In-Reply-To: <8b3a9c3bc1cae8b15954e8925fba9d751a4f051d.1790815412.git.alexander.turenko@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD916CE66F793C04802C62A43F2A1FBB8A221B1D077E2DC85CB00894C459B0CD1B9877795061DD48B6B33594132A326AF8BF6C0182337F98300EEB555D610C6E1D8AB5D286C5C76880D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78CB87876C5D626D4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756681E03DB2D92E72D1CF1315095B08831F05C5FFA0C44EE4A4669976B6F66DC422389733CBF5DBD5E9D5E8D9A59859A8B6E5E764EB5D94DBD4CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7BB1D8AFE8C29F51C731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A52713E02BAF7F5DFA5002B1117B3ED696AD8378DE8EB914FCB74D9144D44E4FCF823CB91A9FED034534781492E4B8EEAD09F854029C6BD0DABDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659D9B94FC2D2E473D79F5B022DD2C90371CE12F5D9636B4A9E157DA2BDDED1C737BCD4777296B2AFD5B8341EE9D5BE9A0A117D433EB36F75BB44A8EB37D617DFE50B5552FAFE7427756536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXOcIETfglQORZ0zpDET4Zrk3igikrdHlWMRK0NMpgZX2AP+qXqN/L60= X-Mailru-Sender: 689FA8AB762F73937C9FA53A4753B3131C563902165BE87EE951E1C61CFD44B05C573DEDDFD12C3EEF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] ci: use sudo to install packages if not root X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Alexander! thanks for the patch! LGTM Sergey On 10/1/26 04:06, Alexander Turenko wrote: > The setup-linux and setup-debuggers actions call `apt` without `sudo`, > which works on our self-hosted runners: the jobs run there as root. The > next commit moves the ARM64 jobs to GitHub-hosted runners, where the > steps run as the runner's regular user, so we have to call `sudo` there. > > If the current user is already `root`, `sudo` is not called: this way we > don't depend on its presence when we don't need it. > > Drafted by an LLM, conducted and corrected by the commit author. > --- > .github/actions/setup-debuggers/action.yml | 6 ++++-- > .github/actions/setup-linux/action.yml | 6 ++++-- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/.github/actions/setup-debuggers/action.yml b/.github/actions/setup-debuggers/action.yml > index c34d4502..e2ac09db 100644 > --- a/.github/actions/setup-debuggers/action.yml > +++ b/.github/actions/setup-debuggers/action.yml > @@ -7,6 +7,8 @@ runs: > uses: ./.github/actions/setup-linux > - name: Install dependencies for the tests > run: | > - apt -y update > - apt install -y python3 gdb lldb > + # GitHub-hosted runners run the steps as a regular user. > + SUDO=$([ "$(id -u)" = 0 ] || echo sudo) > + ${SUDO} apt -y update > + ${SUDO} apt install -y python3 gdb lldb > shell: bash > diff --git a/.github/actions/setup-linux/action.yml b/.github/actions/setup-linux/action.yml > index f0171b83..8f13940a 100644 > --- a/.github/actions/setup-linux/action.yml > +++ b/.github/actions/setup-linux/action.yml > @@ -14,6 +14,8 @@ runs: > shell: bash > - name: Install build and test dependencies > run: | > - apt -y update > - apt -y install cmake gcc make ninja-build perl > + # GitHub-hosted runners run the steps as a regular user. > + SUDO=$([ "$(id -u)" = 0 ] || echo sudo) > + ${SUDO} apt -y update > + ${SUDO} apt -y install cmake gcc make ninja-build perl > shell: bash