From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D27FA28D78
	for <tarantool-patches@freelists.org>; Mon,  3 Sep 2018 06:32:50 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id QnqwJ6jmefvq for <tarantool-patches@freelists.org>;
	Mon,  3 Sep 2018 06:32:50 -0400 (EDT)
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8149D28D82
	for <tarantool-patches@freelists.org>; Mon,  3 Sep 2018 06:32:50 -0400 (EDT)
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 2/5] box: introduce slot_cache
 in key_part
References: <cover.1534332920.git.kshcherbatov@tarantool.org>
 <79ae3b382f52fe1b38d21542a1d34079c0e68934.1534332920.git.kshcherbatov@tarantool.org>
 <befa004d-0de9-2eff-1bc4-84e6edb00d0f@tarantool.org>
 <40d4f349-d660-88c9-a125-f352905b5b72@tarantool.org>
Message-ID: <a7386852-8f88-06d6-edda-e002e2b02569@tarantool.org>
Date: Mon, 3 Sep 2018 13:32:48 +0300
MIME-Version: 1.0
In-Reply-To: <40d4f349-d660-88c9-a125-f352905b5b72@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>, tarantool-patches@freelists.org


> 
>> 2. I do not see where do you update cmp_def in this file. Exactly
>> cmp_def is used in comparators, not key_def.
> key_def_merge makes key_def_set_part that setup invalid epoch 0 for
> every key part.

It is not okay. Why do you discard epoch in a result key_def, if
slots are not changed and still valid?