From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0BAE7256DA
	for <tarantool-patches@freelists.org>; Tue, 30 Jul 2019 15:39:48 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id CQU3XDntS-2r for <tarantool-patches@freelists.org>;
	Tue, 30 Jul 2019 15:39:47 -0400 (EDT)
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id BF5FF255DE
	for <tarantool-patches@freelists.org>; Tue, 30 Jul 2019 15:39:47 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 5/5] sql: introduce VARBINARY
 column type
References: <cover.1563967510.git.korablev@tarantool.org>
 <ff84ee4c2b351d2a8b8fea3e43187bc8de9e92c2.1563967510.git.korablev@tarantool.org>
 <49a188eb-dafe-44e7-a0fd-e9244b68e721@tarantool.org>
 <1293710C-85CC-4F5A-A7CF-4677D901DCE9@tarantool.org>
 <24a34647-0d0c-7950-b92e-6c8bf3f16d92@tarantool.org>
 <63A0BD0D-69A9-4CD6-942B-EB9CDDDB21F3@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <a6fb66a6-452d-7594-610c-3430b6448c66@tarantool.org>
Date: Tue, 30 Jul 2019 21:41:55 +0200
MIME-Version: 1.0
In-Reply-To: <63A0BD0D-69A9-4CD6-942B-EB9CDDDB21F3@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org>

Hi! Thanks for the fixes!

LGTM.

>>>> 3. BLOB keyword is reserved, but also it is used in parse.y:980.
>>>> Should not it be deleted from all the rules, and be just
>>>> reserved?
>>>
>>> It’s rule for declaring blob (aka binary string) literals.
>>> I can rename it, but TBO it looks OK to me.
>>
>> Could you please provide an example, how to use BLOB keyword to
>> declare a literal? I can't find any test, using BLOB in a query
>> string for anything.
> 
> I meant that it’s not the rule that allows BLOB keyword but
> the rule to process X’…’ literals. When string is processed by
> lexer (tokenize.c) its token type is assigned to TK_BLOB.

Ahh, I got it now. BLOB(X) is not a 'BLOB' keyword, it is rather
like a rule 'BLOB := x...'. Then of course it is ok, nothing to
do here.