From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3C3CF4696C4
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 19 Apr 2020 20:02:48 +0300 (MSK)
References: <65798b71932c21183072decd2cce8b2b0f88b884.1585773275.git.alexander.turenko@tarantool.org>
 <78056845-c72f-f97e-de62-2f04baaed0e0@tarantool.org>
 <20200403233859.57lre4ef6co22g3e@tkn_work_nb>
 <61a72f34-7bd0-576e-e305-dfee085ca724@tarantool.org>
 <20200405120544.sktsaxfczlkz4ehq@tkn_work_nb.domru>
 <26b560a7-886b-30e9-58aa-fb4f3b26e559@tarantool.org>
 <20200406113935.fu3zli6s5x4dusgb@tkn_work_nb>
 <26e71870-33fa-9ec2-2493-d565dbc9d0e7@tarantool.org>
 <20200419162327.6hwg7xm4l75izzur@tkn_work_nb>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <a6f59817-8017-e18b-27e6-9d910da8d401@tarantool.org>
Date: Sun, 19 Apr 2020 19:02:46 +0200
MIME-Version: 1.0
In-Reply-To: <20200419162327.6hwg7xm4l75izzur@tkn_work_nb>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] net.box: fix fetching of schema of
 an old version
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 19/04/2020 18:23, Alexander Turenko wrote:
>>> It seems logical to move snapshots out from test suites, since they will
>>> be used across the test suites. What do you think?
>>
>> It is not always the case. A snapshot is ok to use across tests only if
>> it is not related to any particular test more than to others. Only empty
>> snapshots satisfy that criteria. The reason is that we are obligated to
>> keep tests isolated from each other. And if you use one non-empty snapshot
>> for multiple tests, the policy will be violated.
> 
> (Continued snap/upgrade discussion in the sibling email thread.)
> 
> How about this directory structure?
> 
>  test/
>  |
>  +- snap/
>     |
>     +- how_to_add_new_test.md
>     |
>     +- xlog/
>     |  |
>     |  +- gh-4771-upgrade-sequence/
>     |     |
>     |     +- fill.lua
>     |     +- 2.1.3/
>     |        |
>     |        +- *.snap
>     |
>     +- box-tap/
>        |
>        +- gh-4691-net-box-connect-schema-2-1-3/
>           |
>           +- fill.lua
>           +- 2.1.3/
>              |
>              +- *.snap
> 
> Key points:
> 
> * All snapshots are in one place: it is easier to keep them right
>   structured.
> * Snapshots are organized on per-test basis.
> 
> Alternative:
> 
>  test/
>  |
>  +- xlog/
>  |  |
>  |  +- snap/
>  |     |
>  |     +- how_to_add_new_test.md
>  |     |
>  |     +- gh-4771-upgrade-sequence/
>  |        |
>  |        +- fill.lua
>  |        +- 2.1.3/
>  |           |
>  |           +- *.snap
>  |
>  +- box-tap/
>     |
>     +- snap/
>        |
>        +- how_to_add_new_test.md -> ../../xlog/snap/how_to_add_new_test.md
>        |
>        +- gh-4691-net-box-connect-schema-2-1-3/
>           |
>           +- fill.lua
>           +- 2.1.3/
>              |
>              +- *.snap
> 
> Key points:
> 
> * All snapshots organized as same structured subtrees.
> * Same as above, snapshots are organized on per-test basis.
> 
> WBR, Alexander Turenko.

Both options look good to me.