From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 72B7E6EC5D; Mon, 5 Apr 2021 16:18:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 72B7E6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617628689; bh=a8n4JtxCqUmUNnDtv52umqOwLu9AfFnXfbxxz+9OqIk=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=IK3qtDC8LofB0EQqsqIGibnxeLjDNSiu25s4+JLQdZq8RHyDJp8HOcVeZOYVwndyR cvR/ko3mYyUCZv+zQDUWrgdjqYzXt8e/V/ljdh3RvGunakBixEMJ16Z0wPPc27WyrE zqoSu9Gudr1lZAPjydQQCZ64kq2Z2I4cdO9j3lBk= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 317286EC5D for ; Mon, 5 Apr 2021 16:18:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 317286EC5D Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lTP7H-0000Ju-86; Mon, 05 Apr 2021 16:18:07 +0300 To: Serge Petrenko , alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <53f906760f240ea0f381fd693000139e8d5e5c8c.1617375300.git.sergepetrenko@tarantool.org> Message-ID: Date: Mon, 5 Apr 2021 15:18:06 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <53f906760f240ea0f381fd693000139e8d5e5c8c.1617375300.git.sergepetrenko@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709E798FFD99D1B1662182A05F538085040613E8BCF365F89A2290302043100ABB93B3F972A7EE8E0183AF51382C39B3616 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE751DD1FEBB966604DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372A1456D053D20C618638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C16EE06F5A270FE6A771BB74EEA575D304EDBE24C1AFE412AA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C353FA85A707D24CADCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7588D3C263EAE74EA731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: 2623F767319EFA42AC98609FCEE262F9192335DD689A58EBAE0174B7F1092AFBF63472D85867295624133971388C44C8 X-C1DE0DAB: 0D63561A33F958A556623AC57BBAB07FEDF02A7DED55E191018AD1234C538E18D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F3735C80F9F4B96D403545FA2D10DA41089F971DFD589F8E63EF05ED27B0DB7A516D4A4437D68D691D7E09C32AA3244CC5CEFE6B7569414821386AB0EB0EE8AACE0B41342B755BCDFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojM00ve/f+0oknZ+rqgFyItA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638224FF523DCAB4A8734B050696809B283043841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/4] feedback_daemon: send feedback on server start X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! On 02.04.2021 16:58, Serge Petrenko wrote: > Send the first report as soon as instance's initial configuration > finishes. > > Closes #5750 > --- > diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua > index d00eedf39..2ce768642 100644 > --- a/src/box/lua/feedback_daemon.lua > +++ b/src/box/lua/feedback_daemon.lua > @@ -345,7 +345,7 @@ local function guard_loop(self) > while true do > > if get_fiber_id(self.fiber) == 0 then > - self.fiber = fiber.create(feedback_loop, self) > + self.fiber = fiber.new(feedback_loop, self) Why?