From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2EB326EC5D; Thu, 8 Apr 2021 16:41:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2EB326EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617889317; bh=iBNioEeciuzCwLBbVuOcGzl7/nL0nm+CU3zz1QAQyjE=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=J1wTzsxPhh6bAc803XDKOLosc2yIj+OyavokKDdvTGCsCyYQE/u7jlSoG77zUOQum mo0UiRwWQkt6NlR8l02jy+qomWy8V0OHTaQtmu0PEaWg5AwYnqanniCdH5aizXy8JP fVsv7Eb6tYSyTe7qidZmAqK5dxIVp2o0bJOJC3Yk= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 82DCE6EC5D for ; Thu, 8 Apr 2021 16:41:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 82DCE6EC5D Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1lUUud-0000gw-F3; Thu, 08 Apr 2021 16:41:35 +0300 To: v.shpilevoy@tarantool.org, alexander.turenko@tarantool.org Date: Thu, 8 Apr 2021 16:38:38 +0300 Message-Id: X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD912A3E3D5D4B49FC17951DFF5B22C9C640BE5EAB58CFCE0F000894C459B0CD1B98CF73F466364888728CA06204DE97D1538DE5FFF3BE301001473A5891B7656E9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75644E22E05AA81AEB287FD4696A6DC2FA8DF7F3B2552694A4E2F5AFA99E116B42401471946AA11AF176DF2183F8FC7C00F8483684B69468C52120BFB3F63BC18BE95F64BC9A3199D1BDDB23E98D2D38BD6CF32B5F8F9D40446148FDCFD97268D17159D9F961CAD5BCC7F00164DA146DAFE8445B8C89999728AA50765F7900637712AAB6D9D366D8A389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8CE135D2742255B35F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BE79BD65E82DB1F1375ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975CD0035DD76F8A8A4F6115365C036B5AC0EC88A58E27F1AD809C2B6934AE262D3EE7EAB7254005DCED7532B743992DF240BDC6A1CF3F042BAD6DF99611D93F60EF0417BEADF48D1460699F904B3F4130E343918A1A30D5E7FCCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34060C3C6DE316ECE41394D6FC755D79A35EF27E6C6172B85B0BE64C97D921A87EDB9687405FCBA3D21D7E09C32AA3244CB3B7145540AE69FDED30F7FCF012BA4D6C24832127668422927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioju+jaMfvANXpiISknIVVE4Q== X-Mailru-Sender: 3B9A0136629DC9125D61937A2360A4465E4806B976005D2A03E99C7FA510A9BE37A118895F133E23424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: [Tarantool-patches] [PATCH v2 2/5] feedback_daemon: rename `send_test` to `send` X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" feedback_daemon.send() will come in handy once we implement triggers to dispatch feedback after some events, for example, right on initial instance configuration. So, it's not a testing method anymore, hence the new name. Part of #5750 --- src/box/lua/feedback_daemon.lua | 2 +- test/box-tap/feedback_daemon.test.lua | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua index 8820bcde5..d00eedf39 100644 --- a/src/box/lua/feedback_daemon.lua +++ b/src/box/lua/feedback_daemon.lua @@ -412,7 +412,7 @@ setmetatable(daemon, { reload = function() reload(daemon) end, - send_test = function() + send = function() if daemon.control ~= nil then daemon.control:put("send") end diff --git a/test/box-tap/feedback_daemon.test.lua b/test/box-tap/feedback_daemon.test.lua index e1c450d2b..3d6bf1d9b 100755 --- a/test/box-tap/feedback_daemon.test.lua +++ b/test/box-tap/feedback_daemon.test.lua @@ -93,28 +93,28 @@ feedback_reset() errinj.set("ERRINJ_HTTPC", false) check('feedback received after errinj') -daemon.send_test() +daemon.send() check("feedback received after explicit sending") box.cfg{feedback_enabled = false} feedback_reset() -daemon.send_test() +daemon.send() test:ok(feedback_count == 0, "no feedback after disabling") box.cfg{feedback_enabled = true} -daemon.send_test() +daemon.send() check("feedback after start") daemon.stop() feedback_reset() -daemon.send_test() +daemon.send() test:ok(feedback_count == 0, "no feedback after stop") daemon.start() -daemon.send_test() +daemon.send() check("feedback after start") -daemon.send_test() -check("feedback after feedback send_test") +daemon.send() +check("feedback after feedback send") daemon.stop() @@ -136,7 +136,7 @@ server:close() -- check it does not fail without server daemon = box.internal.feedback_daemon daemon.start() -daemon.send_test() +daemon.send() daemon.stop() -- -- 2.24.3 (Apple Git-128)