From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AEA82678420; Wed, 8 Nov 2023 18:47:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AEA82678420 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1699458450; bh=A4nlJqsZMa3iOADsdIec4AqhXOukJInv/LrIrE4FgIo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NWBlGGtRi2JKWzbqf1rBDNByuVn2hRmmbZKKd/dD/sv5gvSzOCF9ORHwmzQDTcK5M Hdu4mDQVskidmPME+4EGYRJzF14kH9OdowWradQTSOj/NlsJc70si3o+XU57QruQ8P WnKaVg0IAdvYVfO3F2DZfXwBYJFuueHmkHeZqK2A= Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [95.163.41.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4ADBC48FA78 for ; Wed, 8 Nov 2023 18:47:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4ADBC48FA78 Received: by smtp36.i.mail.ru with esmtpa (envelope-from ) id 1r0km8-002lod-1O; Wed, 08 Nov 2023 18:47:28 +0300 Content-Type: multipart/alternative; boundary="------------W5CWC2IcMLLS0gCx3kfQ3znp" Message-ID: Date: Wed, 8 Nov 2023 18:47:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maxim Kokryashkin References: <20230710122818.22221-1-m.kokryashkin@tarantool.org> <9aec4ca0-09c0-2692-81e6-5d391f06fd7b@tarantool.org> <1689345019.547057052@f380.i.mail.ru> In-Reply-To: <1689345019.547057052@f380.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9C2A6B03AB739174C0F639123EF19B3582BE6F954B2C8A81E00894C459B0CD1B99677282F61CB29C871BF476F64F05F9BCB95E7E00CFD54A829B867418450F35B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922D113DFDC6D5A3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B5932F77F0041FFB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DB666FFF0B2864A11581D70680ABBC27117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3733B5EC72352B9FA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B18F49F126DDB898E8D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F254576263B31EA99735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB861051D4BA689FC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FF841BD135A60A31757739F23D657EF2BB5C8C57E37DE458BEDA766A37F9254B7 X-B7AD71C0: 6FEFE4C63DFE2D85718F43753FD9AD21390936EE2A242988633761F9DFDC81E9D5050B8102AA647D33B1FE034477C273 X-C1DE0DAB: 0D63561A33F958A56CC68192F3746B5C4DA46643613124876E5394035A5404F6F87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC71106E36FF2641B7B8424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34A5970F8A4685C8AB4B2565C0030C6B6E4DDF234593BAE4A3A9A9C6BB9F930A85285780E9F94F15421D7E09C32AA3244CA165EA7FE34B5F300401DD8BA7EF31C564EE5813BBCA3A9DBAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGx6zOZpnTNBIBr9v3Dku5Q== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769290F9AD1D13CDD1612EE96F89477B5EC7958A49548C749F6EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3] sysprof: fix crash during FFUNC stream X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------W5CWC2IcMLLS0gCx3kfQ3znp Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Max sorry for a delayed answer. LGTM with a minor comment On 7/14/23 17:30, Maxim Kokryashkin wrote: > > > > > +end > > + > > +res, err = misc.sysprof.stop() > > +assert(res, err) > > + > > +test:ok(true, 'sysprof finished successfully') > I propose to reflect a goal of the test in a test description. Please add something about ffunc to description. The test is not about whole sysprof, but about ffunc support in sysprof. > > + > > +os.exit(test:check() and 0 or 1) > > --------------W5CWC2IcMLLS0gCx3kfQ3znp Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Max

sorry for a delayed answer.

LGTM with a minor comment


On 7/14/23 17:30, Maxim Kokryashkin wrote:

<snipped>
 

> +end
> +
> +res, err = misc.sysprof.stop()
> +assert(res, err)
> +
> +test:ok(true, 'sysprof finished successfully')

I propose to reflect a goal of the test in a test description. Please add something about ffunc to description.

The test is not about whole sysprof, but about ffunc support in sysprof.

> +
> +os.exit(test:check() and 0 or 1)

--------------W5CWC2IcMLLS0gCx3kfQ3znp--