From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] replication: fix flaky gh-3160-misc... test
Date: Thu, 9 Dec 2021 00:45:04 +0100 [thread overview]
Message-ID: <a5f7b16c-5a64-dd56-e3eb-b393b6dc4291@tarantool.org> (raw)
In-Reply-To: <20211208104454.20345-1-sergepetrenko@tarantool.org>
Hi! Thanks for the patch!
LGTM. Even though it is already pushed.
As for the email vs PR. I am fine with reviewing PRs if the emails make it
harder to Vova. Although I still prefer receiving emails in case I am the
only reviewer. Or all the other reviewers prefer emails too.
next prev parent reply other threads:[~2021-12-08 23:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 10:44 Serge Petrenko via Tarantool-patches
2021-12-08 11:00 ` Vladimir Davydov via Tarantool-patches
2021-12-08 11:13 ` Serge Petrenko via Tarantool-patches
2021-12-08 11:25 ` Vladimir Davydov via Tarantool-patches
2021-12-08 11:56 ` Serge Petrenko via Tarantool-patches
2021-12-08 23:45 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-12-09 10:19 ` Serge Petrenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5f7b16c-5a64-dd56-e3eb-b393b6dc4291@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] replication: fix flaky gh-3160-misc... test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox