From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 13087469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 20 Nov 2020 22:40:52 +0300 (MSK)
References: <cover.1605570907.git.v.shpilevoy@tarantool.org>
 <0f6505cf411bd9e7e11f42b5b6a8526b6b291ce1.1605570907.git.v.shpilevoy@tarantool.org>
 <5b1bfa71-72d9-7f4e-27b8-5ad3ee0b8951@tarantool.org>
 <39072609-6bbf-b159-f787-5e738bcb72a2@tarantool.org>
 <c3ca7784-e061-fc1a-5130-6526b41042fe@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <a5f064bd-f7be-8e30-4fc4-32a9a796f779@tarantool.org>
Date: Fri, 20 Nov 2020 20:40:51 +0100
MIME-Version: 1.0
In-Reply-To: <c3ca7784-e061-fc1a-5130-6526b41042fe@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH 08/12] raft: introduce vtab for disk
 and network
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>, tarantool-patches@dev.tarantool.org, gorcunov@gmail.com

>>>> diff --git a/src/box/raft.c b/src/box/raft.c
>>>> index af6e71e0b..845525660 100644
>>>> --- a/src/box/raft.c
>>>> +++ b/src/box/raft.c
>>>> @@ -29,7 +29,10 @@
>>>>     * SUCH DAMAGE.
>>>>     */
>>>>    #include "box.h"
>>>> +#include "error.h"
>>>> +#include "journal.h"
>>>>    #include "raft.h"
>>>> +#include "relay.h"
>>>>    #include "replication.h"
>>> Just noticed: raft.c starts depending on xrow.h in this patch.
>> This is fine. box/raft.c can depend on anything. It is raftlib.c/.h,
>> who is not allowed to depend on anything except src/lib.
> 
> I meant you should include xrow.h here directly.

Aha, ok. I thought that it is enough to have it implicitly through other
files. But I don't mind adding it.

====================
@@ -34,6 +34,7 @@
 #include "raft.h"
 #include "relay.h"
 #include "replication.h"
+#include "xrow.h"