From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E56A020A7C for ; Wed, 30 Jan 2019 08:57:00 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J9cyf2qSaoWk for ; Wed, 30 Jan 2019 08:57:00 -0500 (EST) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 91AE5201F5 for ; Wed, 30 Jan 2019 08:57:00 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v5 4/6] sql: fix "PRAGMA case_sensitive_like" result References: <318f3a258e8ce5326b5a346c5924396d40991049.1548771900.git.imeevma@gmail.com> From: Vladislav Shpilevoy Message-ID: Date: Wed, 30 Jan 2019 16:56:58 +0300 MIME-Version: 1.0 In-Reply-To: <318f3a258e8ce5326b5a346c5924396d40991049.1548771900.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, imeevma@tarantool.org Cc: korablev@tarantool.org On 29/01/2019 17:29, imeevma@tarantool.org wrote: > Currently PRAGMA case_sensitive_like returns nothing. This seems > wrong, since other similar pragmas return their status. Fixed in > the current patch. > --- > src/box/sql/pragma.c | 23 +++++++++-------------- > src/box/sql/pragma.h | 7 +++---- > src/box/sql/sqliteInt.h | 2 ++ > test/sql/misc.result | 17 +++++++++++++++++ > test/sql/misc.test.lua | 10 ++++++++++ > 5 files changed, 41 insertions(+), 18 deletions(-) Why the previous commit puts a pragma-related test into gh-***-pragma.test.lua, but this puts into misc.test.lua? Please, be consistent. Move this test into the same file as the previous commit did.