From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C59DB30BDB for ; Thu, 13 Jun 2019 18:24:41 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Cf8sjmiECRlt for ; Thu, 13 Jun 2019 18:24:41 -0400 (EDT) Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8772B30C43 for ; Thu, 13 Jun 2019 18:24:41 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 15/28] sql: remove SQL_SCHEMA errcode References: <623be9993a866d7796ae3f2a60397550eac1007e.1560174553.git.imeevma@gmail.com> From: Vladislav Shpilevoy Message-ID: Date: Fri, 14 Jun 2019 00:24:57 +0200 MIME-Version: 1.0 In-Reply-To: <623be9993a866d7796ae3f2a60397550eac1007e.1560174553.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, imeevma@tarantool.org Thanks for the patch! Consider my review fix below and on the branch in a separate commit. ====================================================== diff --git a/src/box/sql/prepare.c b/src/box/sql/prepare.c index 827828a1a..d909c8bf1 100644 --- a/src/box/sql/prepare.c +++ b/src/box/sql/prepare.c @@ -209,7 +209,7 @@ sqlReprepare(Vdbe * p) /* * Two versions of the official API. Legacy and new use. In the legacy * version, the original SQL text is not saved in the prepared statement - * and so if a schema change occurs, SQL_SCHEMA is returned by + * and so if a schema change occurs, an error is returned by * sql_step(). In the new version, the original SQL text is retained * and the statement is automatically recompiled if an schema change * occurs.