From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 482A04765E0
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 25 Dec 2020 10:07:03 +0300 (MSK)
References: <cover.1606766417.git.sergeyb@tarantool.org>
 <ce3bb1f82c97a2fa077a41640c6ae9f9bf74a1e4.1606766417.git.sergeyb@tarantool.org>
 <20201207172444.GE5396@tarantool.org>
 <51ad8f7a-c804-7e06-ceb9-0c8adcc56d16@tarantool.org>
 <20201220133109.GN5396@tarantool.org>
 <1cc806a8-62d2-947b-eb74-efd80dafca49@tarantool.org>
 <20201224132254.GA5396@tarantool.org>
 <2ab21816-244d-7fd7-48cf-4e7076fbb64f@tarantool.org>
 <20201224175034.GB5396@tarantool.org>
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <a5704ae3-4087-1660-50d6-5b9f5b842e51@tarantool.org>
Date: Fri, 25 Dec 2020 10:07:01 +0300
MIME-Version: 1.0
In-Reply-To: <20201224175034.GB5396@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH 1/4] test: add infrastructure for
 fuzzing testing and fuzzers
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org


On 24.12.2020 20:50, Igor Munkin wrote:
> Sergey,
>
> On 24.12.20, Sergey Bronnikov wrote:
>> Igor,
>>
> <snipped>
>
>>>>>>> 2. Do you need to specify <address> flag once more, when ASAN is
>>>>>>> enabled? If not the hunk above looks excess, doesn't it?
>>>>>> Agree, it was a bad idea to manage UBSan and ASAN flags in yet another
>>>>>> place.
>>> I guess this should be fixed in scope of the first patch, but I see you
>>> squashed it to the last one. Why?
>> It seems because I was triggered by OSS_FUZZ in hunk and squashed it to
>> a commit
>>
>> that introduce an OSS_FUZZ support. Fixed it and also moved
>> add_compile_options() to the first commit too
>>
>> (otherwise project source code is not instrumented with
>> -fsanitize=fuzzer-no-link).
> OK, but I believe we agreed the <address> options should be removed to
> avoid managing ASAN flags here, didn't we?

Removed asan option and double space in commit message.

--- a/test/fuzz/CMakeLists.txt
+++ b/test/fuzz/CMakeLists.txt
@@ -9,12 +9,23 @@ add_library(fuzzer_config INTERFACE)
  target_compile_options(
      fuzzer_config
      INTERFACE
+        $<$<NOT:$<BOOL:${OSS_FUZZ}>>:
          -fsanitize=fuzzer
+        >
+        $<$<BOOL:${OSS_FUZZ}>:
+        ${CXX}
+        ${CXXFLAGS}
+        >
  )
  target_link_libraries(
      fuzzer_config
      INTERFACE
+        $<$<NOT:$<BOOL:${OSS_FUZZ}>>:
          -fsanitize=fuzzer
+        >
+        $<$<BOOL:${OSS_FUZZ}>:
+        $ENV{LIB_FUZZING_ENGINE}
+        >
  )

>
> <snipped>
>