From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8E62D469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 10 Nov 2020 23:38:45 +0300 (MSK)
References: <cover.1604057827.git.kyukhin@tarantool.org>
 <f41063a688c3a5facb32340638cf66b9c27e5404.1604057827.git.kyukhin@tarantool.org>
 <a2094254-6032-1be2-14d2-26f3b37a92b6@tarantool.org>
 <20201102073503.i7cdfb2qc3xt7fjf@tarantool.org>
 <e9c793a7-304e-6624-820a-3b114bec0571@tarantool.org>
 <20201110141651.sa7al2ms7ggx2jxe@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <a52ef5b1-aca3-8bf7-7f06-4e8cb12ce769@tarantool.org>
Date: Tue, 10 Nov 2020 21:38:43 +0100
MIME-Version: 1.0
In-Reply-To: <20201110141651.sa7al2ms7ggx2jxe@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 5/5] Apply Clang formatter
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

> On 02 Nov 22:05, Vladislav Shpilevoy wrote:
>> Ok. I will review the whole patch, every single line. Don't push
>> it beforehand then.
> 
> In my previous e-mail I've explicitly stated that current formatter
> is not suitable for us. Quote:
> 
>>> After all, having p.3 and p.8 unresolved I guess we cannot proceed
>>> without changes to formatter.
> 
> Please, see what does it mean here [1].
> 
> [1] - https://translate.google.com/#view=home&op=translate&sl=auto&tl=ru&text=After%20all%2C%20having%20p.3%20and%20p.8%20unresolved%20I%20guess%20we%20cannot%20proceed%20without%20changes%20to%20formatter.

Ok, lets play quotes. Here is yours:

	I am not sure. Anyway I think this is not a blocker for having fully automated
	code formatting.

Talking of this quote:

	After all, having p.3 and p.8 unresolved I guess we cannot proceed
	without changes to formatter.

It is not the same as saying that we won't use the formatter. You just said,
you will try to fix review points 3 and 8. Which were not even the worst.
Which leads to the point you are ok with the other issues. Tons of
other issues, as I found in the detailed review. And I am not ok with these
issues.