From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3D61F6EC40; Thu, 19 Aug 2021 13:29:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3D61F6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1629368963; bh=UZhLo43LmH5UD9Up7JGuGf9zhKFxGgNBCKO3wPnmkQs=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tNb2Z3EEBvXy1pIT0lXH7cQl1K3odqhYG4rZQswgk2wwZtgE8a59Y/q+hOW+2/nUH MB7k0B73MXJOSnpHwxJYM2ohhdq+mySbH19FyqJLytriYb1oysuo/JDkzvaWtPcMdn ZNJbVeBXJsMy7Ht/sTMiqgkZUL6sAasCAPNJ9Sd8= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BC48C6EC40 for ; Thu, 19 Aug 2021 13:29:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BC48C6EC40 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1mGfIW-0008Rr-4Z; Thu, 19 Aug 2021 13:29:20 +0300 To: Serge Petrenko , vdavydov@tarantool.org, tarantool-patches@dev.tarantool.org References: <82319534-df35-ceb6-ee22-cb4cbaff5e41@tarantool.org> Message-ID: Date: Thu, 19 Aug 2021 13:29:06 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <82319534-df35-ceb6-ee22-cb4cbaff5e41@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD972FF4A7D76DB5E242D14FEF1BD8BF4AC182A05F53808504053F732587FD3C03AFA44F6B46D897A468F75302EEABC94F831E418E150FCDA48 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77E216A0E97507353EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371E8C7BD479B346ED8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D815854B7241C8E2AA2BA68D3152218A90117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC60CDF180582EB8FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE7B96B19DC4093321E21AE983DBD7FFC1D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE362B3BD3CC35DA588040F9FF01DFDA4A8C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006377870F476E0DB9443EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5C44BF5499BA4270FCB8A0B96B4BE640594F2BB48C1490F82D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758B25CD4253D1D611410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A5BF8FA0BD61F99496FA045F64041EEB2B9E6B8C22365B6464748DDFF319AB8E119C88E0A402FE761D7E09C32AA3244C9C433E69560D20583EADFB88651F9EA063871F383B54D9B3DCA3B3C10BC03908 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGSxK+6r6oBHBgKSxTPzEAw== X-Mailru-Sender: 6CA451E36783D721CBEA96CEA26D325D8CA00B0D075DE7B4C0F8E96A2E500947B7CBEF92542CD7C82F97C478340294DCC77752E0C033A69E0F0C7111264B8915FF1320A92A5534336C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v6 4/5] datetime: perf test for datetime parser X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Safin Timur via Tarantool-patches Reply-To: Safin Timur Cc: v.shpilevoy@tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 19.08.2021 13:19, Serge Petrenko wrote: > > > 19.08.2021 05:56, Timur Safin пишет: >> It was told that if field `datetime.secs` would be `double` we should get >> better performance in LuaJIT instead of `uint64_t` type, which is used >> at the >> moment. >> >> So we have created benchmark, which was comparing implementations of >> functions >> from `datetime.c` if we would use `double` or `int64_t` for >> `datetime.secs` field. >> >> Despite expectations, based on prior experience with floaing-point on x86 >> processors, comparison shows that `double` provides similar or >> sometimes better timings. And picture stays consistent be it SSE2, >> AVX1 or >> AVX2 code. >> >> Part of #5941 >> --- > > I agree with Vladimir here. > Looks like this perf test doesn't belong to Tarantool repository. > Would you mind dropping it? Here is the case (we both aware of) I want to avoid here - today we do not have saved _that_ decimal perf test, basing on which we have preferred LuaC and dropped FFI implementation. We could not rerun it today, within a newer LuaJIT implementation, to verify that situation didn't change. This is similar case - we have made a decision basing on some evaluations using this code, in a future we may decide to further optimize data structure (like Vova suggested elsewhere to split int64 into 2 fields), and it would be better if at that moment we would still have performance test around for adaptations and rerun. Yes, it's another test of performance test we used to see in perf directory (hehe, there is only single test at the moment), kind of one time shot in a history, important for design decision, but from longer prospective I assume it should be still around. Does my reasoning make some sense? Thanks, Timur