From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A5E474696C3 for ; Tue, 7 Apr 2020 23:29:40 +0300 (MSK) From: Vladislav Shpilevoy References: <15594780-32ed-abf0-5c39-9b0c7d9438c5@tarantool.org> Message-ID: Date: Tue, 7 Apr 2020 22:29:38 +0200 MIME-Version: 1.0 In-Reply-To: <15594780-32ed-abf0-5c39-9b0c7d9438c5@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v2 0/2] box: fix session.push formatting List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Sosnin , tarantool-patches@dev.tarantool.org Hi! I suggest to hurry up, we have the release closer and closer. On 04/04/2020 01:42, Vladislav Shpilevoy wrote: > Thanks for the fixes! > > The patchset LGTM. Except that the changelog is still > missing. > > Please, add a changelog, and send on a second review. > I propose either Nikita or Alexander L. > > On 13/03/2020 15:58, Chris Sosnin wrote: >> issue: https://github.com/tarantool/tarantool/issues/4686 >> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4686-session-push-fmt >> >> Changes in v2: >> - Current format moved to struct session. >> - Applied review fixes. >> >> Chris Sosnin (2): >> refactoring: store output format in struct session >> box: fix formatting in session.push >> >> extra/exports | 2 + >> src/box/lua/console.c | 53 ++++++++++++++++++-------- >> src/box/lua/console.lua | 72 +++++++++++++++++++++++++++-------- >> src/box/session.h | 22 ++++++++--- >> test/app-tap/console.test.lua | 14 ++++++- >> 5 files changed, 126 insertions(+), 37 deletions(-) >>