From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 85AB3469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 17 Mar 2020 01:29:33 +0300 (MSK)
References: <7720185c4456a63f0d31bfbe11cdb101e864a3c4.1584284911.git.v.shpilevoy@tarantool.org>
 <20200316124817.GA14628@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <a49916bb-2375-e126-d6c7-bb1147b6e229@tarantool.org>
Date: Mon, 16 Mar 2020 23:29:31 +0100
MIME-Version: 1.0
In-Reply-To: <20200316124817.GA14628@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 1/1] fiber: extend max fiber name
 length to 255
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Indeed. Ask everyone to add them, and forgot myself.

@ChangeLog
- Fiber.name maximal length is extended to 255 (gh-4394).

On 16/03/2020 13:48, Nikita Pettik wrote:
> On 15 Mar 16:11, Vladislav Shpilevoy wrote:
>> Users keep complaining about too short fiber name. New limit is
>> 255, should be enough for any sane name.
>>
>> Closes #4394
>>
>> @TarantoolBot document
>> Title: fiber.name length limit.
>>
>> It was 32, now it is 255. Besides, it seems like `fiber.name`
>> `{truncate = true}` option is not documented.
>>
>> By default, if a new name is too long, `fiber.name(new_name)`
>> fails with an exception. To make it always succeed there is an
>> option 'truncate': `fiber.name(new_name, {truncate = true})`. It
>> truncates the name to the max length if it is too long.
>> ---
>> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4394-fiber-name-inline
>> Issue: https://github.com/tarantool/tarantool/issues/4394
>>
>> Changes in v2:
>> - Short fiber names are kept inside struct fiber.
>>
> 
> LGTM. Seems you forgot to add changelog for github release.
>  
>