From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 744E4469719
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 22 Feb 2020 20:18:16 +0300 (MSK)
References: <cover.1582119629.git.korablev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <a482d611-ad89-4737-fcab-20fde059621b@tarantool.org>
Date: Sat, 22 Feb 2020 18:18:14 +0100
MIME-Version: 1.0
In-Reply-To: <cover.1582119629.git.korablev@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 0/7] Stacked diagnostics area
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for the patchset!

Please, add a changelog record. I think it should be two separate
records, for each ticket.

On 19/02/2020 15:16, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/commits/np/gh-1148-stacked-diag
> Issue:
> https://github.com/tarantool/tarantool/issues/1148
> https://github.com/tarantool/tarantool/issues/4778
> 
> Patch-set basically consists of two parts: first one fixes undocumented
> behaviour of box.error.new() which sets created error to diagnostics
> area. The reason why it is required is described in the corresponding
> github ticked. Second part is about stacked diagnostics itself: patch
> error structure extending it with double linked list, provide Lua and
> C interfaces to interact with it, support stacked diagnostics in IProto
> protocol and net.box module (all points according to the rfc: 
> https://github.com/tarantool/tarantool/commit/1acd32d98f628431429b427df19caa9d269bb9c8).