From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 777627030F; Thu, 25 Feb 2021 00:48:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 777627030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614203295; bh=W+QN94O4LyQe85u6mVuIysLEqFQ5fC/0HXeDP//dK6Y=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Np9BaOkZeylK6OjO1IP3PTq7DRvGCnIA8uzG8FpmISjt2EpDce+Rk7HHW8l73aWc9 m70G2qjyiBi6jeMFRGgXAAmg49VD+zl/Ljk92/avMgZASo2KDNY6U1BetJy/VpL59j 33hQz4lJGYWh/njWHlByhBSCOy165Bme5zrrTOsE= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AEEDC7030F for ; Thu, 25 Feb 2021 00:48:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AEEDC7030F Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1lF20y-0000RG-Pb; Thu, 25 Feb 2021 00:48:13 +0300 To: Oleg Babin , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org References: <8be0f758-10ae-98e5-d6f5-359db7eaf7cd@tarantool.org> Message-ID: Date: Wed, 24 Feb 2021 22:48:11 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <8be0f758-10ae-98e5-d6f5-359db7eaf7cd@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD975C3EC174F56692243410BA6471F01668A37AB103014B813182A05F538085040CF0312625F5CE9D863014B71E6E2DD76785FE74DCF0AA385949DD96FE0A4BBCB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71BDE6A359BD5B800EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C867FEFF36BCDF178638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCEF6CC647C0669FAF64729B0B8CFD3D0D3B2118E753E6BF06389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0DEC8C2C8BCD2534D8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6A0EE70D6C4970CA7A471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCB009DDF5C0E26B253AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F790063779EEAB775419CB88D81D268191BDAD3D698AB9A7B718F8C442539A7722CA490C13377AFFFEAFD26923F8577A6DFFEA7CB24F08513AFFAC7993EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B610E4EE32A3E37749089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E7025EC15B47EAE72BACBD9CCCA9EDD067B1EDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5A1FE5358DD4D088EF8F6B6ED8C2FCA3ECD3A5EE4DFA281C2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75968C9853642EB7C3410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3419891600CCEF4607158C74837D18D523317494EA86C41005681EAD700DE95D6707B3E0FAF9E26F4D1D7E09C32AA3244CB6D4E52F64A6A03386E2C6220CFC069E5A1673A01BA68E40FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojvz1c9SWJtj+F37w2U7wC+A== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110699A8064728F861F78ED3904E9BA56988A38CBEE4001014907784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 05/11] util: introduce safe fiber_cond_wait() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the review! On 24.02.2021 11:27, Oleg Babin wrote: > Hi! Thanks for your patch. LGTM. > > I see several usages of cond:wait() in code. Maybe after introducing this helper you could use it. > > E.g. in "bucket_send_xc" function. Yeah, I checked the existing usages, but it is fine as is there. In bucket_send_xc() it is ok to throw. This is why it is 'xc' - 'exception'. It is ok, because there are other ops which can throw, and eventually I decided not to wrap them all into pcalls. In global fibers I kept the normal waits, because its throw here is fine. They don't have any finalization work to do after the waits.